On Fri, 28 Feb 2025 01:45:00 -0600
izzy Meyer <izder...@disroot.org> wrote:
>
> FWIW, both FreeBSD and NetBSD's port for this software set SUID for
> these binaries w/o extra patching or overrides, but for some
> reason, my port doesn't set SUID.
>
[..snip]
>
> Minor question, I actually don't see SUID being set with my diff when
> installed on my system, but inside of the fake install, it is SUID?
> Does this not get preserved when packaging or something?
>
Okay, figured it out. I needed to put @mode 4755 in the PLIST. This way
we can avoid the post-install: target. WRKSRC/src/common.mf handles the
setuid automagically, we just need to persist it in the package. After
a little reading, xmsession is actually a script, so we shouldn't
setuid it. Big oversight on my part.
Here's a new diff with the above changes, and REVISION changed back to
0 (rather than 1).
This *does* work correctly for me.
--
iz (she/her)
> i like to say mundane things,
> there are too many uninteresting things
> that go unnoticed.
izder456 (dot) neocities (dot) org
Index: Makefile
===================================================================
RCS file: /cvs/ports/x11/emwm-utils/Makefile,v
diff -u -r1.1.1.1 Makefile
--- Makefile 23 Aug 2024 06:03:38 -0000 1.1.1.1
+++ Makefile 28 Feb 2025 09:18:39 -0000
@@ -1,6 +1,7 @@
COMMENT = session manager and a toolchest-like application launcher
V = 1.2
+REVISION = 0
DISTNAME = emwm-utils-src-${V}
PKGNAME = emwm-utils-${V}
Index: pkg/PLIST
===================================================================
RCS file: /cvs/ports/x11/emwm-utils/pkg/PLIST,v
diff -u -r1.1.1.1 PLIST
--- pkg/PLIST 23 Aug 2024 06:03:38 -0000 1.1.1.1
+++ pkg/PLIST 28 Feb 2025 09:18:39 -0000
@@ -1,4 +1,5 @@
bin/xmsession
+@mode 4755
@bin bin/xmsm
@bin bin/xmtoolbox
lib/X11/app-defaults/XmSm
