On Mon, Feb 24, 2025 at 1:14 AM Fred <open...@crowsons.com> wrote:
>
> On 23-02-2025 16:21, Theo Buehler wrote:
> >> If I remember correctly, this is fixed by upgrading devel/lua-lgi to
> >> version 0.9.2.
> >
> > It's probably worth updating even if it's not directly releated to the
> > crash. 0.9.1 segfaults during 'make test', 0.9.2 just fails, so that
> > might be a slight improvement.
> >
> > Since awesome is the only consumer of this, it would be nice if an
> > awesome user could try this.
> >
> > Index: Makefile
> > ===================================================================
> > RCS file: /cvs/ports/devel/lua-lgi/Makefile,v
> > diff -u -p -r1.35 Makefile
> > --- Makefile 11 Mar 2022 18:50:44 -0000 1.35
> > +++ Makefile 23 Feb 2025 16:17:06 -0000
> > @@ -2,10 +2,9 @@ COMMENT= lua bindings to libraries using
> >
> > GH_ACCOUNT= pavouk
> > GH_PROJECT= lgi
> > -GH_TAGNAME= 0.9.1
> > +GH_TAGNAME= 0.9.2
> >
> > PKGNAME= lua-${DISTNAME}
> > -REVISION= 1
> > CATEGORIES= devel
> >
> > # MIT
> > Index: distinfo
> > ===================================================================
> > RCS file: /cvs/ports/devel/lua-lgi/distinfo,v
> > diff -u -p -r1.11 distinfo
> > --- distinfo 28 Feb 2017 11:32:16 -0000 1.11
> > +++ distinfo 23 Feb 2025 16:14:12 -0000
> > @@ -1,2 +1,2 @@
> > -SHA256 (lgi-0.9.1.tar.gz) = DHD7KxyhfTM7fiwY1fyUOUS1hy4GPeYN8wNe4gttr7o=
> > -SIZE (lgi-0.9.1.tar.gz) = 287130
> > +SHA256 (lgi-0.9.2.tar.gz) = z8QQVIK0cws6QAl8nZ5+NcRt8vslU3C96y9FqIZUjE8=
> > +SIZE (lgi-0.9.2.tar.gz) = 291463
> > Index: patches/patch-lgi_Makefile
> > ===================================================================
> > RCS file: /cvs/ports/devel/lua-lgi/patches/patch-lgi_Makefile,v
> > diff -u -p -r1.5 patch-lgi_Makefile
> > --- patches/patch-lgi_Makefile 11 Mar 2022 18:50:44 -0000 1.5
> > +++ patches/patch-lgi_Makefile 23 Feb 2025 16:17:23 -0000
> > @@ -1,5 +1,6 @@
> > ---- lgi/Makefile.orig Fri May 27 21:56:36 2016
> > -+++ lgi/Makefile Tue Feb 28 11:53:21 2017
> > +Index: lgi/Makefile
> > +--- lgi/Makefile.orig
> > ++++ lgi/Makefile
> > @@ -8,8 +8,8 @@
> > PREFIX = /usr/local
> > HOST_OS = $(shell uname -s | tr A-Z a-z)
> > @@ -13,7 +14,7 @@
> > GINAME = gobject-introspection-1.0
> > @@ -27,7 +27,7 @@ LIBFLAG = -bundle -undefined dynamic_lookup
> > CCSHARED = -fno-common
> > - GOBJECT_INTROSPECTION_LIBDIR = $(shell pkg-config --variable=libdir
> > $(GINAME))
> > + GOBJECT_INTROSPECTION_LIBDIR = $(shell $(PKG_CONFIG) --variable=libdir
> > $(GINAME))
> > else
> > -CORE = corelgilua51.so
> > +CORE = corelgilua${MODLUA_DEP_VERSION}.so
> > Index: patches/patch-lgi_core_c
> > ===================================================================
> > RCS file: /cvs/ports/devel/lua-lgi/patches/patch-lgi_core_c,v
> > diff -u -p -r1.7 patch-lgi_core_c
> > --- patches/patch-lgi_core_c 11 Mar 2022 18:50:44 -0000 1.7
> > +++ patches/patch-lgi_core_c 23 Feb 2025 16:17:15 -0000
> > @@ -1,6 +1,7 @@
> > ---- lgi/core.c.orig Tue Feb 28 11:57:18 2017
> > -+++ lgi/core.c Tue Feb 28 11:58:03 2017
> > -@@ -673,7 +673,7 @@ set_resident (lua_State *L)
> > +Index: lgi/core.c
> > +--- lgi/core.c.orig
> > ++++ lgi/core.c
> > +@@ -684,7 +684,7 @@ set_resident (lua_State *L)
> > }
> >
> > G_MODULE_EXPORT int
> > Index: patches/patch-tests_Makefile
> > ===================================================================
> > RCS file: /cvs/ports/devel/lua-lgi/patches/patch-tests_Makefile,v
> > diff -u -p -r1.7 patch-tests_Makefile
> > --- patches/patch-tests_Makefile 11 Mar 2022 18:50:44 -0000 1.7
> > +++ patches/patch-tests_Makefile 23 Feb 2025 16:17:34 -0000
> > @@ -1,7 +1,8 @@
> > - Ensure the libraries needed by libregress.so can also be located and
> > are preloaded.
> >
> > ---- tests/Makefile.orig Tue Feb 28 11:55:06 2017
> > -+++ tests/Makefile Tue Feb 28 11:57:01 2017
> > +Index: tests/Makefile
> > +--- tests/Makefile.orig
> > ++++ tests/Makefile
> > @@ -26,7 +26,7 @@ endif
> > endif
> >
> > @@ -18,8 +19,8 @@
> > - cd .. && LD_LIBRARY_PATH=tests:$$LD_LIBRARY_PATH \
> > + cd .. && LD_PRELOAD=/usr/lib/libpthread.so
> > LD_LIBRARY_PATH=tests:$$LD_LIBRARY_PATH \
> > GI_TYPELIB_PATH=tests:$$GI_TYPELIB_PATH \
> > - LUA_PATH=./?.lua\;`$(LUA) -e "print(package.path)"` \
> > - LUA_CPATH=./?.so\;`$(LUA) -e "print(package.cpath)"` \
> > + LUA_PATH="./?.lua;${LUA_PATH};" \
> > + LUA_CPATH="./?.so;${LUA_CPATH};" \
> > @@ -76,7 +76,7 @@ Regress-1.0.gir : $(REGRESS)
> > --namespace=Regress --nsversion=1.0 \
> > --include=cairo-1.0 --include=Gio-2.0 \
> > Index: pkg/PLIST
> > ===================================================================
> > RCS file: /cvs/ports/devel/lua-lgi/pkg/PLIST,v
> > diff -u -p -r1.11 PLIST
> > --- pkg/PLIST 11 Mar 2022 18:50:44 -0000 1.11
> > +++ pkg/PLIST 23 Feb 2025 16:18:55 -0000
> > @@ -1,5 +1,5 @@
> > lib/lua/${MODLUA_VERSION}/lgi/
> > -lib/lua/${MODLUA_VERSION}/lgi/corelgi${MODLUA_DEP}.so
> > +@so lib/lua/${MODLUA_VERSION}/lgi/corelgi${MODLUA_DEP}.so
> > share/examples/${FULLPKGNAME}/
> > share/examples/${FULLPKGNAME}/GDbus/
> > share/examples/${FULLPKGNAME}/GDbus/list-system-services.lua
> > @@ -9,6 +9,7 @@ share/examples/${FULLPKGNAME}/cairo.lua
> > share/examples/${FULLPKGNAME}/clutterdemo.lua
> > share/examples/${FULLPKGNAME}/console.lua
> > share/examples/${FULLPKGNAME}/giostream.lua
> > +share/examples/${FULLPKGNAME}/goocanvas.lua
> > share/examples/${FULLPKGNAME}/gstplaystream.lua
> > share/examples/${FULLPKGNAME}/gstvideo.lua
> > share/examples/${FULLPKGNAME}/gtk-demo/
> > @@ -99,6 +100,7 @@ share/lua/${MODLUA_VERSION}/lgi/override
> > share/lua/${MODLUA_VERSION}/lgi/override/Gdk.lua
> > share/lua/${MODLUA_VERSION}/lgi/override/Gio-DBus.lua
> > share/lua/${MODLUA_VERSION}/lgi/override/Gio.lua
> > +share/lua/${MODLUA_VERSION}/lgi/override/GooCanvas.lua
> > share/lua/${MODLUA_VERSION}/lgi/override/Gst.lua
> > share/lua/${MODLUA_VERSION}/lgi/override/Gtk.lua
> > share/lua/${MODLUA_VERSION}/lgi/override/Pango.lua
> >
>
> Hi Theo & David,
>
> I applied this patch and rebuilt both lgi and awesome.
>
> awesome is now running, and there are no regressions so far.
>
> Thanks
>
> Fred
Ok, I was wrong in my previous email.
The segfault should happen if you switch from "default" theme to the
"gtk" theme, and this segfault is related to lgi 0.9.1.
