Thank you very much Johannes.

Your changes work perfectly and I upgraded to v2.4.4.

OK ?

Denis

On Mon, Feb 10, 2025 at 08:33:32PM +0000, Johannes Thyssen Tishman wrote:
> 2025-01-13T13:24:17+0100 Denis Fondras <de...@openbsd.org>:
> > A CLI GlobalProtect VPN client, written in Rust, based on OpenConnect
> > and Tauri, supports SSO with MFA, Yubikey, and client certificate
> > authentication, etc.
> > 
> > https://github.com/yuezk/GlobalProtect-openconnect/
> > 
> > I disabled the GUI build because it requires nodejs.
> 
> Hi Denis, thank you for this. I had been looking for an alternative for
> openconnect-sso. I didn't have time to test it, but here are ome notes
> on the port:
> 
> Should we maybe use gp-openconnect as PKGNAME? I feel like it's easier to
> read.
> 
> HOMEPAGE is unnecessary as GH_* sets it already.
> 
> The following build dependencies are missing:
> devel/gmake
> textproc/jq
> 
> Crates licenses are missing:
> $ make makesum
> $ make modcargo-gen-crates > crates.inc
> $ make makesum
> $ make modcargo-gen-crates-licenses > /tmp/crates.licenses \
>       && mv /tmp/crates.licenses crates.inc
> 
> 'make port-lib-depends-check' reports that net/openconnect should be in
> LIB_DEPENDS and with that, the following WANTLIB's are missing:
> WANTLIB += crypto openconnect ssl
> 
> Can we perhaps use openconnect-light instead? Less dependencies.
> 
> Not sure this is needed, but maybe it is better to override do-build
> with the default make command?
> 
> do-build:
>       @cd ${WRKSRC} && env -i ${MAKE_ENV} ${MAKE_PROGRAM} ${MAKE_FLAGS} \
>               -f ${MAKE_FILE} build BUILD_GUI=0
> 
> At build time, the port tries to write .cargo/.global-cache to $HOME and
> it fails, but it continues to build. Seems harmless but we can get rid
> of this wtth PORTHOME = ${WRKBUILD}.
> 
> Attached is a port with the above changes and with variables sorted
> according to Makefile.template.
> 


Attachment: gp-openconnect-2.4.4.tgz
Description: application/tar-gz

Reply via email to