On Fri, 7 Feb 2025 15:29:57 -0800
Andrew Hewus Fresh <and...@afresh1.com> wrote:

> -sub new {
> -     my ($class, $dir, $tweak_wantlib, $lib_depends_tgt) = @_;
> +sub new($class, $dir, $tweak_wantlib, $lib_depends_tgt = undef) {

> -sub verbose {
> -     my $self = shift;
> +sub verbose($self, $set = undef) {

> -sub _adj_whitespace {
> -     my ($self, $var, $value, $wssample) = @_;
> -     
> +sub _adj_whitespace($self, $var, $value, $wssample = undef) {

Do we need "= undef" in these 3 signatures?  The callers seem to pass
all arguments, so I deleted all 3 "= undef" in my copy.  All of your
signatures look correct to me.

You have multiple "use v5.40;" lines, one in each package.  It is
correct, but I would prefer to have only one "use v5.40;" above the
1st "package" line.

--gkoehler

Reply via email to