On 2025/02/08 12:40, Stuart Henderson wrote: > On 2025/02/08 13:29, Martijn van Duren wrote: > > On Sat, 2025-02-08 at 11:23 +0000, Stuart Henderson wrote: > > > Trying to build with this diff, several patches are failing to apply > > > (some completely, some partially). Are there some removed patch files > > > that aren't showing in the diff? > > > > Yes, I put the list of removed patches in my first two mails, but > > failed to repeat them in my previous mail: > > aha, thanks - leaving it building now and will take another look later. > (including them in the diff is generally simplest for testers) >
a couple of nits: - "make plist" added a file, lib/libmocks_test.a - it should be either added, disabled, or @comment'ed in the PLIST, whichever is most appropriate (do we need to install any of those static libs?) - "make port-lib-depends-check" reports this, 0ad-0.27.0(games/0ad/base): Missing: wx_baseu_net-3.2.0 from wxWidgets-gtk3-3.2.6p2 (/usr/local/lib/libAtlasUI.so) Missing: wx_baseu_xml-3.2.0 from wxWidgets-gtk3-3.2.6p2 (/usr/local/lib/libAtlasUI.so) Extra: ogg.6 vorbis.9 WANTLIB += wx_baseu_net-3.2 wx_baseu_xml-3.2 the missing libs should be added. with those changes, OK sthen (perhaps the Extra libs could be removed but listing a couple of Extras isn't as much of a problem as missing a lib, so I'd be inclined to leave that for now.)
