On 2025/01/14 21:37, Stuart Henderson wrote:
> On 2025/01/14 17:19, Stuart Cassoff wrote:
> > I'd like to add MULTI_PACKAGES to an upcoming Jimtcl update.
> > He's the new Makefile and a diff. Does that look ok?
> 
> Makefile and diff are totally mangled.

also,

> > PKGNAME-main =        ${PKGNAME}

i think that's set by default these days

> > LIB_DEPENDS-redis =    lang/jimtcl,-main databases/libhiredis
> > LIB_DEPENDS-sdl =    lang/jimtcl,-main devel/sdl2-gfx devel/sdl2-ttf
> > LIB_DEPENDS-sqlite =    lang/jimtcl,-main databases/sqlite3

it's customary to use one line per library here

> > .include <bsd.port.arch.mk>
> > 
> > .if ${BUILD_PACKAGES:M-redis}
> > CONFIGURE_ARGS +=    --with-mod=redis
> > .endif
> > 
> > .if ${BUILD_PACKAGES:M-sdl}
> > CONFIGURE_ARGS +=    --with-mod=sdl
> > .endif
> > 
> > .if ${BUILD_PACKAGES:M-sqlite}
> > CONFIGURE_ARGS +=    --with-mod=sqlite3
> > .endif

those BUILD_PACKAGES:M don't do anything unless you also setup
no_XXX PSEUDO_FLAVORS.

These aren't too onerous as build deps, so I'd suggest just listing them
in the main block of CONFIGURE_ARGS and not making them conditional.

Reply via email to