Joel, I had noticed that go-1.23.4 has been released for about a month ago and I would like to update it.
Release notes says: go1.23.4 (released 2024-12-03) includes fixes to the compiler, the runtime, the trace command, and the syscall package. See the Go 1.23.4 milestone on our issue tracker for details. https://github.com/golang/go/issues?q=milestone%3AGo1.23.4+label%3ACherryPickApproved Well, this update doesn't requrie one of our patches anymore, since: https://github.com/golang/go/commit/777f43ab27bde4c662cd0a663f807f74f3fbab0f Otherwise it is clean update. Tested on -current/amd64 and -current/arm64 make test runs the same way on both machines before and after this diff. Ok? Index: Makefile =================================================================== RCS file: /home/cvs/ports/lang/go/Makefile,v diff -u -p -r1.157 Makefile --- Makefile 8 Nov 2024 14:25:40 -0000 1.157 +++ Makefile 14 Jan 2025 16:00:13 -0000 @@ -7,7 +7,7 @@ COMMENT = Go programming language # increment _MODGO_SYSTEM_VERSION in go.port.mk after updating to a new # version, to trigger updates of go-compiled ports -VERSION = 1.23.3 +VERSION = 1.23.4 DISTNAME = go${VERSION}.src PKGNAME = go-${VERSION} PKGSPEC = ${FULLPKGNAME:S/go-/go-=/} Index: distinfo =================================================================== RCS file: /home/cvs/ports/lang/go/distinfo,v diff -u -p -r1.99 distinfo --- distinfo 8 Nov 2024 14:25:40 -0000 1.99 +++ distinfo 14 Jan 2025 16:00:42 -0000 @@ -3,10 +3,10 @@ SHA256 (go-openbsd-amd64-bootstrap-1.22. SHA256 (go-openbsd-arm-bootstrap-1.22.5.tar.gz) = hd5uX+7C1KPYDhhh3GjexRShYcZR6qOVNmmr7nrINmE= SHA256 (go-openbsd-arm64-bootstrap-1.22.5.tar.gz) = jfRynOQVoniG2ZvzZgHExVUEzKFOlfEWPEW43/NaZtQ= SHA256 (go-openbsd-riscv64-bootstrap-1.22.5.tar.gz) = 7uKbM7V/XPXVfeJMdEDG57hzhoao5hv1vzpsal+YPiw= -SHA256 (go1.23.3.src.tar.gz) = jWp3MySHVXxq+iQhExtQ+D20rjxXnDvHLmcO4faWhZk= +SHA256 (go1.23.4.src.tar.gz) = rTRaxCHpCBQpOpaZzKGd1SOCUcP2h5gLvK4oSVsmNTE= SIZE (go-openbsd-386-bootstrap-1.22.5.tar.gz) = 69567775 SIZE (go-openbsd-amd64-bootstrap-1.22.5.tar.gz) = 79553441 SIZE (go-openbsd-arm-bootstrap-1.22.5.tar.gz) = 77558960 SIZE (go-openbsd-arm64-bootstrap-1.22.5.tar.gz) = 76871926 SIZE (go-openbsd-riscv64-bootstrap-1.22.5.tar.gz) = 77931440 -SIZE (go1.23.3.src.tar.gz) = 28173788 +SIZE (go1.23.4.src.tar.gz) = 28177188 Index: go.port.mk =================================================================== RCS file: /home/cvs/ports/lang/go/go.port.mk,v diff -u -p -r1.79 go.port.mk --- go.port.mk 8 Nov 2024 14:26:45 -0000 1.79 +++ go.port.mk 14 Jan 2025 16:00:28 -0000 @@ -1,6 +1,6 @@ # increment after a go compiler update to trigger updates of # compiled go packages (see arch-defines.mk) -_MODGO_SYSTEM_VERSION = 19 +_MODGO_SYSTEM_VERSION = 20 ONLY_FOR_ARCHS ?= ${GO_ARCHS} Index: patches/patch-src_time_time_test_go =================================================================== RCS file: patches/patch-src_time_time_test_go diff -N patches/patch-src_time_time_test_go --- patches/patch-src_time_time_test_go 8 Nov 2024 14:25:40 -0000 1.3 +++ /dev/null 1 Jan 1970 00:00:00 -0000 @@ -1,12 +0,0 @@ -Index: src/time/time_test.go ---- src/time/time_test.go.orig -+++ src/time/time_test.go -@@ -1085,7 +1085,7 @@ func TestLoadFixed(t *testing.T) { - name, offset := Now().In(loc).Zone() - // The zone abbreviation is "-01" since tzdata-2016g, and "GMT+1" - // on earlier versions; we accept both. (Issue #17276). -- if !(name == "GMT+1" || name == "-01") || offset != -1*60*60 { -+ if !(name == "GMT+1" || name == "-01" || name == "+01") || offset != -1*60*60 { - t.Errorf("Now().In(loc).Zone() = %q, %d, want %q or %q, %d", - name, offset, "GMT+1", "-01", -1*60*60) - } -- wbr, Kirill