Hello, I have submitted a PR which adds me to MAINTAINER. Please check it
https://github.com/jasperla/openbsd-wip/pull/180 Thanks, Carter > 2024/12/18 04:30, izzy Meyer <izder...@disroot.org> wrote: > > On Sat, 7 Dec 2024 05:59:03 +0000 > Li Carter <zhangsong...@live.cn> wrote: > >>> As I said: >>> >>> I see it builds against headers for various libraries in >>> BUILD_DEPENDS but dlopen()'s them at runtime and no run dependency >>> information is recorded in the package, >> >> As I said, it's designed like that. You should not force people that >> don't use xfce installing xfconf. >> >>> therefore there's no way to get this automatically updated if there >>> are API changes in those libraries, short of somebody monitoring >>> about a dozen ports for changes and manually bumping REVISION where >>> needed. This doesn't seem a great approach for ports. >> >> Most dependencies of fastfetch are stable and commonly used. I don't >> think they will introduce break changes often. In addition, fastfetch >> has been packaged by FreeBSD and a lot of Linux distros and they >> share the most dependencies. If one dependency introduces >> incompatible API or ABI changes which breaks fastfetch, it will >> affect not only OpenBSD but also FreeBSD and Linux users. As long as >> one of them files a bug in fastfetch github repo, I can fix it. >> > > Okay, if you're willing to do this, please put your name and email down > in MAINTAINER. This way, in the event that this port breaks due to an > ABI change, people know who to contact to fix it. I committed this port > to the openbsd-wip repo with a small TODO file: > > https://github.com/jasperla/openbsd-wip/tree/master/sysutils/fastfetch > > This is a repository for ports that are currently in the works. I > recommend working on this tree when building new ports. The Readme file > in the repo explains how to use it. > >> >> I see OpenBSD has neofetch packaged. Despite neofetch is written in >> bash which doesn't seem to have API problems, it executes 3rd-party >> commands. What if those commands change the formation of their >> output? I don't see anyone complains it's problematic. >> > > This is a far point. I'd have to agree with you on this. See my above > comment. > > All in all, thanks for your work Carter. Its truly appreciated. The > port works pretty dang well, and its nice to see this utility on > OpenBSD. > > Thanks- > > -- > iz (they/them) > >> i like to say mundane things, >> there are too many uninteresting things >> that go unnoticed. > > izder456 (dot) neocities (dot) org
