Greetings, Thanks for review!
On Sat, 14 Dec 2024 14:21:59 +0100, Klemens Nanni <k...@openbsd.org> wrote: > > 12.12.2024 04:39, Kirill A. Korinsky пишет: > > ports@, > > > > I'd like to import devel/intellij-fsnotifier which is port for > > https://gitlab.com/worthwhileit/bsd/fsnotifier which is used at FreeBSD. > > NO_TEST=Yes can be dropped, I think; cmake just finds 0 tests, but can pick > up > new ones in future releases. > Indeed, removed. > Why remove the header and library? > > Why not build and ship a dynamic library as usual? Then the port actually > gets > bumped/rebuilt on inotify updates and post-install remains a single program > rename. > Out of the box this project uses static libraries, and I not sure that any other port may use it as library. But I don't mind to install it if it make things cleaner. > I see no pledge usage under WRKSRC and libinotify doesn't use it, so the > Makefile > comment is wrong. > Wrong copy-paste, fixed. > The patches look like you could send them upstream. Either way, brief > comments > about what they fix/improve are useful, imho. > Already did: https://gitlab.com/worthwhileit/bsd/fsnotifier/-/merge_requests/1 Anyway, I had added into patches the same link. > COMMENT says "fsnotifier", but the README diffs below have "fsNotifier". > Which one is right? > > In README: > - "for Intellij-based such as": needs capital J, misses "IDE" or so before > "such" > - use active voice for brevity: "should be integrated by ..." -> "enable it > via" Fixed > - avoid drama like "dramatically" and keep it short or describe the > requirements; > libinotify's README already has it, so perhaps just refer to that and/or > provide > some numbers? Numbers depends on the project. But IDE says when limits is too low, so I removed this part. > > --- devel/intellij/pkg/README 25 Jan 2023 10:54:32 -0000 1.6 > > +++ devel/intellij/pkg/README 12 Dec 2024 01:38:28 -0000 > > @@ -13,6 +13,10 @@ Native Libraries > > ================ > > Functionality depending on native libraries is not likely to work. > > > > +Filesystem notifier > > +=================== > > +You may find a replacment of fsNotifier as devel/intellij-fsnotifier. > > Does fsNotifier already exist in intellij and is your new port an alternative > implementation? Then perhaps briefly explain why users benifit from it? > > Or does it add currently missing functionality? > > Looks like both since only one IDE has it: > $ pkglocate fsnotifier > pycharm-2024.1.4:devel/pycharm:/usr/local/pycharm/bin/fsnotifier > > > Either way, I suggest active voice in such places, e.g. > > Install the intellij-fsnotfier package to use fsNotifier. > Addressed. Both Intellij IDEA and Pycharm ships fsnotifier which is compiled for Linux, and which doesn't work on OpenBSD. Anyway, here an updated diff and tgz: Index: devel/intellij/Makefile =================================================================== RCS file: /home/cvs/ports/devel/intellij/Makefile,v diff -u -p -r1.99 Makefile --- devel/intellij/Makefile 8 Sep 2024 02:15:54 -0000 1.99 +++ devel/intellij/Makefile 12 Dec 2024 01:38:49 -0000 @@ -1,6 +1,7 @@ COMMENT= IntelliJ IDEA Java IDE V= 2024.2.1 +REVISION= 0 DISTNAME= ideaIC-${V} PKGNAME= intellij-${V} CATEGORIES= devel Index: devel/intellij/pkg/README =================================================================== RCS file: /home/cvs/ports/devel/intellij/pkg/README,v diff -u -p -r1.6 README --- devel/intellij/pkg/README 25 Jan 2023 10:54:32 -0000 1.6 +++ devel/intellij/pkg/README 14 Dec 2024 14:17:21 -0000 @@ -13,6 +13,10 @@ Native Libraries ================ Functionality depending on native libraries is not likely to work. +Filesystem notifier +=================== +Install the intellij-fsnotfier package to use fsNotifier. + Errors After Upgrading ====================== If you receive errors starting after an upgrade, try the following: Index: devel/pycharm/Makefile =================================================================== RCS file: /home/cvs/ports/devel/pycharm/Makefile,v diff -u -p -r1.56 Makefile --- devel/pycharm/Makefile 25 Jul 2024 23:28:21 -0000 1.56 +++ devel/pycharm/Makefile 12 Dec 2024 01:38:56 -0000 @@ -1,6 +1,7 @@ COMMENT= Python IDE based on IntelliJ IDEA V= 2024.1.4 +REVISION= 0 DISTNAME= pycharm-community-${V} PKGNAME= pycharm-${V} CATEGORIES= devel Index: devel/pycharm/pkg/README =================================================================== RCS file: /home/cvs/ports/devel/pycharm/pkg/README,v diff -u -p -r1.3 README --- devel/pycharm/pkg/README 11 Mar 2022 18:53:06 -0000 1.3 +++ devel/pycharm/pkg/README 14 Dec 2024 14:17:09 -0000 @@ -8,3 +8,7 @@ If the splash-screen displays but you th install the wmname package and run 'wmname LG3D'. This is a problem that has been seen with some Java-based applications used with a non-reparenting window manager (e.g. cwm). + +Filesystem notifier +=================== +Install the intellij-fsnotfier package to use fsNotifier. -- wbr, Kirill
intellij-fsnotifier.tgz
Description: Binary data
