On 2024/12/12 17:56, Martijn van Duren wrote:
> On Thu, 2024-12-12 at 16:06 +0000, Stuart Henderson wrote:
> > On 2024/12/12 15:40, Martijn van Duren wrote:
> > > There appear to be 2 branches of releases, the main 6.4.3 release, and
> > > the -r<n> releases which are annotated as for docker. While the release
> > > notes give the impression that there are only docker related changes, a
> > > got diff on the tags shows that there are also code changes included in
> > > there. For this reason it seemed best to lucas and me to follow the
> > > latter.
> >
> > Doesn't seem to be the case for 4.6.3, but looking at older releases
> > I see what you mean. What a nuisance.
> >
> > > +V = 4.6.3-r0
> > > +DISTFILES = ${V}.tar.gz
> > > +DISTNAME = coturn-docker-${V}
> > > +PKGNAME = turnserver-${V:S/-/./}
> > ...
> > > PORTROACH = site:https://github.com/coturn/coturn/releases/
> > > -SITES = https://coturn.net/turnserver/v${V}/
> > > +SITES = https://github.com/coturn/coturn/archive/refs/tags/docker/
> >
> > Please use GH_* for github autogenerated tarballs, it takes care
> > of renaming the downloaded files a bit better than the default,
> >
> > > +SHA256 (4.6.3-r0.tar.gz) = yIFrwM9YQT5Y6r8EDtTCHp8kHKk6cEVja1Dow0BsTrk=
> > > +SIZE (4.6.3-r0.tar.gz) = 535329
> >
> > ...this isn't really suitable for use in distfiles.
> >
> > Also, while things will work with the way you're setting PKGNAME
> > for -r0 to -r9, it will break at -r10 (which they have used before)
> > and then you'd need to start using EPOCH (use pkg_check-versions to
> > check the sort order).
> >
> > / in the tag name adds a slight complication but it's not too
> > hard to deal with.
> >
> > Makefile diff below will fix that.
>
> Copied over your suggestion
> >
> > (I didn't try building, the diff in your email got mangled somewhere
> > and I didn't fancy hand-applying the changes to patches/).
> >
> Apparently evolution decided to apply quoted printable to it... Need to
> figure out how to fix that at a later time (suggestions welcome). For
> now I've simply attached the diff.
The qp wasn't a problem (from mutt/neomutt, I view the main message body
part rather than just the "autoview" of the whole message, and | patch ...)
but it had also decided to strip out tabs, which is trickier.
Diffs as MIME attachments are fine on ports@ as far as I'm concerned.
> tb@ pointed out offlist that the libressl version number stuff can go.
> I already did that for ns_ioalib_engine_impl.c, but for 4.6.2 (which I
> was working on originally) the mainrelay.c bits were still needed.
Thanks, that looks in good shape. I'm not running TURN here, but looking
at changelog there are plenty of fixes we want in there.
OK sthen
