On Thu, Jul 19, 2007 at 11:54:18PM -0500, Gilles Chehade wrote:
> 1- even though the PLIST starts with @newuser, the user does not get
>       created and I am forced to create it manually. Anyone can
>       explain what I do wrong ?

You mean during fake stage? Well, the user is created add install
time, i.e. when you run pkg_add(8) or make install.

At least I can't build it here because it tries to chown some stuff
to _news during fake.

ksh: }fmt: not found
floating around the archives), especially on patch-support_install-sh.
Unfortunately, Deannas port seems to be unavailable.



> 2- this one being my first port, I probably did some thing(s) wrong,
>       it would be great if someone could review and tell me what I
>       need to fix and what could/should be improved/changed.

Some nits:

* COMMENT doesn't need quotes any longer.

* --with-etc-dir=${PREFIX}/share/examples/inn looks wrong, it should be
  set to ${SYSCONFDIR}/news or similar. Same vor --with-db-dir, let
  it point to /var/news/db. Funny enough, looking at my own old
  port, I see lots of fishy things there, too, e.g. using ${LOCALBASE}
  instead of ${PREFIX} in setting CONFIGURE_ARGS.

* your patch-Makefile_global_in looks strange, too. I'm not sure wether
  WRKINST is guaranteed to be in the environment or passed to make.
  In general, if you want to override things like DESTDIR, try to
  add them to the environment, using MAKE_ENV or MAKE_FLAGS resp.
  FAKE_FLAGS depending on your needs before starting to patch things.

> 3- I am not very familiar with inn, maybe some more experienced user
>       can help with the default config file and examples ?

Well, years ago I used to use a much older version of INN, on a
leaf site, with UUCP, so I'm not of the biggest help here until I
get the time to read all the documentation.


>       - needs /usr NOT to be nosuid (innd requires to be called
[...]

That's no problem, we've other ports that need suid.

Ciao,
        Kili

Reply via email to