On Mon, Oct 23, 2023 at 05:15:31PM +0200, Otto Moerbeek wrote:
> Hi,
> 
> upcomng dnsdist has incoming DoQ (DNS over QUIC) supoport using the
> quiche library.

Please add

# ring-v0.16.20 does not support those archs
NOT_FOR_ARCHS = powerpc64 riscv64 sparc64

at the top of the makefile. ring 0.17 adds powerpc64 support, but that
isn't out yet.

> So here's a port of that library. Since it links with boringssl, which
> is static-only, I made this one static-only as well. That avoid quite
> some issues.

rust knocks out quite a few architectures, then ring removes powerpc64,
riscv64 and sparc64 and then it doesn't really matter anymore that
boringssl removes all big-endian architectures.

Is it possible to make DoQ optional in dnsdist so that it keeps being
available on less mainstream architectures? Or is it not worth it?

> I'm not using the crate install command, as the crate does not seem to
> be setup in such a way to allow for that. 

Yes, that seems the right choice, although I think you want

MODCARGO_INSTALL =      No

rather than NO_INSTALL

> As I'm still a port-newbie, any feedbakc is very welcome.

Apart from the above, the port looks good to me. I haven't managed to
figure out how to run tests.

Reply via email to