10/20/23 18:46, Rafael Sadowski пишет:
> Hi ports, Hi bulk builders,
>
> I would like to disable building tests in KDE frameworks applications.
> In a short test in devel/kf, this saves 25% build time.
>
> If someone wants to run the tests, they can simply set the flag to Yes.
>
> I hope that the bulk builds will be significantly faster and we do not
> build that many do not need.
>
> What is your opinion about it?
Makes sense to me, but I'm not a bulk builder.
>
> Rafael
>
> diff --git a/devel/kf5/kf5.port.mk b/devel/kf5/kf5.port.mk
> index 0a0894ba8e9..cba68f81091 100644
> --- a/devel/kf5/kf5.port.mk
> +++ b/devel/kf5/kf5.port.mk
> @@ -1,5 +1,7 @@
> MODKF5_VERSION = 5.110.0
>
> +MODKF5_BUILD_TESTING ?= No
Since you default it here...
> +
> .if empty(GH_ACCOUNT)
> EXTRACT_SUFX ?= .tar.xz
> .endif
> @@ -30,6 +32,11 @@ CONFIGURE_ARGS += \
> # The module needs more fixes. Also, it's not clear how to deal
> # with multiple Python dependencies.
> CONFIGURE_ARGS += -DCMAKE_DISABLE_FIND_PACKAGE_PythonModuleGeneration=ON
> +
> +.if defined(MODKF5_BUILD_TESTING) && ${MODKF5_BUILD_TESTING:L} == "no"
it is always defined here, so why the first test at all?
> +CONFIGURE_ARGS += -DBUILD_TESTING=OFF
> +.endif
> +
> .endif
>
> # make sure cmake module preceeds qt5, unless we really want qmake
>
