Hi Stuart,
> > In Makefile, could you make the following changes?
> >
> > - remove DISTFILES variable => no longer necessary
>
> already done in a tree sweep
Thanks, I missed your commit to delete unnecessary DISTFILES variable in
Makefile.
> > - replace SITES.{a,b,c} and DISTFILES.{a,b,c} with more
> > understandable
> > values
> >
> > SITES.luv = https://github.com/luvit/luv/archive/
> > DISTFILES.luv = luv-{}${LUV_VER}${EXTRACT_SUFX}
> >
> > SITES.LuaJIT = https://github.com/LuaJIT/LuaJIT/archive/
> > DISTFILES.LuaJIT = luajit-{}${LUAJIT_VER}${EXTRACT_SUFX}
> >
> > SITES.lua-compat-5.3 =
> > https://github.com/keplerproject/lua-
> > compat-5.3/archive/
> > DISTFILES.lua-compat-5.3 = lua-compat-5.3-{}${LUACOMPAT_VER}$
> > {EXTRACT_SUFX}
>
> DIST_TUPLE is exactly made for this situation, diff using that below
Great :) I hadn't looked at how to use DIST_TUPLE since bsd.port.mk rework for
SITES/DISTFILES by espie@ during the last Hackathon.
Very useful to define sites/version/URL for additional dependencies.
> no big opinion on before/after 7.4, though I would tend not to unless
> it fixes something important, given that there are some fairly
> machine-dependent parts to the build which have changed i.e. new luajit
> version, and we probably won't learn about breakage on some archs until it's
> too late to fix
As also said by Edd, this Neovim update is a minor release but with update for
external deps (LuaJIT, luv).
I agree to wait after 7.4 release to update this port : more time to check
build/tests on other archs than amd64.
Laurent
