On 2023/09/27 18:02, Theo Buehler wrote:
> On Wed, Sep 27, 2023 at 04:43:37PM +0100, Stuart Henderson wrote:
> > On 2023/09/27 15:49, Theo Buehler wrote:
> > > This is a simple OpenVPN plugin that a client of henning would like to
> > > have. The released version 1.0 is not compatible with OpenSSL 1.1 API,
> > > which is not a great sign, but the code doesn't look too terrible.
> > >
> > > It ships an .so. Not sure if that needs to be versioned and if so, how.
> >
> > It's just a module that gets dlopen()'d by openvpn, no version needed.
> >
> > The .a is of no use at all - "LIBTOOL_FLAGS= --tag=disable-static"
> > skips building it.
> >
> > It's unlikely that the .la will be useful either - the only plugin
> > loader I've seen that wants that is openldap's which uses ltdl.
> > So I think that can probably be skipped too (no fancy way, but
> > rm or @comment would do).
> >
> > I would avoid autoconf 2.68 unless regenerating a script which was
> > originally generated with 2.68 (and even then I might go for something
> > newer if it works) - it was a short lived fairly buggy release.
> > I'd go for either of 2.69 or 2.71, they both work fine for this.
> >
>
> Thanks for the explanations. Yes, 2.68 is a remnant from experimenting
> before I figured out what to set in AUTORECONF. I should have looked
> closer at that AC_PREREQ([2.68]) line...
ah yes, that's a minimum.
> So attached is a new tarball with the following diff to the previous
> one. The generated .so is exactly the same.
ok
> diff -pu -r /tmp/openvpn-otp/Makefile ./Makefile
> --- /tmp/openvpn-otp/Makefile Wed Sep 27 15:46:44 2023
> +++ ./Makefile Wed Sep 27 17:52:44 2023
> @@ -17,8 +17,10 @@ BUILD_DEPENDS= net/openvpn
>
> CONFIGURE_STYLE= autoreconf
> AUTORECONF= ${WRKSRC}/autogen.sh
> -AUTOCONF_VERSION= 2.68
> +AUTOCONF_VERSION= 2.71
> AUTOMAKE_VERSION= 1.16
> +
> +LIBTOOL_FLAGS= --tag=disable-static
>
> DEBUG_PACKAGES= ${BUILD_PACKAGES}
>
> diff -pu -r /tmp/openvpn-otp/pkg/PLIST ./pkg/PLIST
> --- /tmp/openvpn-otp/pkg/PLIST Wed Sep 27 12:49:30 2023
> +++ ./pkg/PLIST Wed Sep 27 17:47:40 2023
> @@ -1,4 +1,3 @@
> lib/openvpn/
> -lib/openvpn/openvpn-otp.a
> -lib/openvpn/openvpn-otp.la
> +@comment lib/openvpn/openvpn-otp.la
> @so lib/openvpn/openvpn-otp.so
