On 2023/09/26 19:27, A Tammy wrote:
>
> On 9/26/23 18:52, JR Aquino wrote:
> > Attached you will find the proposed new addition of the UnrealIRCD Port for
> > OpenBSD
> >
> > I have tested everything based upon the OpenBSD Porting Guide documentation
> > and everything appears to be in full working order.
> >
> > Attached in the tarball
>
>
> thanks, this will be a nice one to have. even better if we can sneak it
> in by 7.4 (seems unlikely though).
>
> A few comments.
>
> Remove DISTNAME, EXTRACT_SUFX, and bunch of other values which are
> already the default. I'd suggest with trying to start removing things
> and if a clean build of the port still works. This will give you a good
> idea of whats redundant and what isn't.
>
> Your BUILD_DEPENDS on gmake should be change to say USE_GMAKE=Yes
>
> Your CONFIGURE_ARGS seems extremely verbose and it seems very likely
> that a lot of it can be trimmed down.
>
> The LIB_DEPENDS on libtool is almost certainly incorrect (haven't built
> the port yet). Maybe you should set USE_LIBTOOL=gnu and see if that
> suffices - https://man.openbsd.org/bsd.port.mk.5#USE_LIBTOOL
it uses libltdl
> A lot of the variables that you''ve set, like RUNDIR, CONFDIR don't seem
> correct. CONFDIR being inside /usr/local is definitely incorrect, it
> needs to be just /etc/unrealircd.
${SYSCONFDIR}
> Also curious why the do-install target had to be manually written out,
> what's wrong with the autoconf installation? If you need to add extra
> files manually, do it in a post-install step.
there's a bunch of ${WRKINST}/usr/local which should be ${PREFIX} though
yes better to use autoconf installation
others:
why the empty pre-configure?
just running "make configure" compiles libargon2 and shouldn't,
it should probably use security/argon2 instead. (also the compile
run as part of configure uses -O3 -march=native, which will
produce broken packages)
it uses a bunch of SUBST_VARS for things which don't appear in
PLIST/etc
RUN_DEPENDS for libraries which should be LIB_DEPENDS
> Overall, a pretty good start, hope this all helps.
there is a fair bit of work still to do, it won't make 7.4
