Antoine Jacoutot wrote (2023-09-16 11:31 CEST):
> On Sat, Sep 16, 2023 at 11:28:13AM +0200, Stefan Hagen wrote:
> > Volker Schlecht wrote (2023-09-15 23:21 CEST):
> > > On my amd64 systems espeak-ng does not produce audio output.
> > >
> > > Interestingly it seems to have broken with the last commit:
> > >
> > > https://cvsweb.openbsd.org/cgi-bin/cvsweb/ports/audio/espeak/Makefile?rev=1.27&content-type=text/x-cvsweb-markup
> > >
> > > because when I add CPPFLAGS to CONFIGURE_ENV, it does actually
> > > speak, but it seems to be somehow important, that there are no
> > > line breaks in CONFIGURE_ENV.
> > >
> > > i.e. with the below patch it produces audio output. Does that
> > > make sense to anyone?
> >
> > Hi,
> >
> > I think your mail program has wrapped the lines in the patch. It doesn't
> > apply like this.
> >
> > I don't understand what you mean with the lines break in CONFIGURE_ENV.
> >
> > This works for me:
> > CONFIGURE_ENV= LDFLAGS="-L${LOCALBASE}/lib -L${X11BASE}/lib" \
> > CPPFLAGS="-I${LOCALBASE}/include"
> >
> >
> > The reason for why CPPFLAGS are needed is in the configure output.
> >
> > Without setting CPPFLAGS, pcaudiolib support will be disabled, because
> > configure is unable to find the header:
> > PCAudioLib: no
> >
> > Once CPPFLAGS is set correctly:
> > PCAudioLib: yes
> >
> > OK sdk@ for the fixed patch below.
> >
> >
> > Index: audio/espeak/Makefile
> > ===================================================================
> > RCS file: /cvs/ports/audio/espeak/Makefile,v
> > retrieving revision 1.27
> > diff -u -p -u -p -r1.27 Makefile
> > --- audio/espeak/Makefile 1 Jun 2023 20:58:21 -0000 1.27
> > +++ audio/espeak/Makefile 16 Sep 2023 09:23:59 -0000
> > @@ -4,7 +4,7 @@ GH_ACCOUNT= espeak-ng
> > GH_PROJECT= espeak-ng
> > GH_TAGNAME= 1.51
> > PKGNAME= ${DISTNAME:S/-ng//}
> > -REVISION= 1
> > +REVISION= 2
> >
> > SHARED_LIBS += espeak-ng 0.0 # 2.51
> >
> > @@ -29,7 +29,9 @@ AUTORECONF= ./autogen.sh
> >
> > CONFIGURE_STYLE= autoreconf
> > # upstream is doing something odd and doesn't add LDFLAGS/CXXFLAGS if
> > CPPFLAGS is set
> > -CONFIGURE_ENV= LDFLAGS="-L${LOCALBASE}/lib -L${X11BASE}/lib"
> > +
> > +CONFIGURE_ENV= LDFLAGS="-L${LOCALBASE}/lib -L${X11BASE}/lib" \
> > + CPPFLAGS="-I${LOCALBASE}/include"
>
> What about the comment above CONFIGURE_ENV?
Probably outdated.
The generated Makefile after the patch:
CPPFLAGS = -I/usr/local/include
LDFLAGS = -L/usr/local/lib -L/usr/X11R6/lib
The generated Makefile before the patch shows:
CPPFLAGS =
LDFLAGS = -L/usr/local/lib -L/usr/X11R6/lib
No change on the LDFLAGS.
I think we can remove the comment.
Index: audio/espeak/Makefile
===================================================================
RCS file: /cvs/ports/audio/espeak/Makefile,v
retrieving revision 1.27
diff -u -p -u -p -r1.27 Makefile
--- audio/espeak/Makefile 1 Jun 2023 20:58:21 -0000 1.27
+++ audio/espeak/Makefile 16 Sep 2023 09:42:04 -0000
@@ -4,7 +4,7 @@ GH_ACCOUNT= espeak-ng
GH_PROJECT= espeak-ng
GH_TAGNAME= 1.51
PKGNAME= ${DISTNAME:S/-ng//}
-REVISION= 1
+REVISION= 2
SHARED_LIBS += espeak-ng 0.0 # 2.51
@@ -28,8 +28,9 @@ AUTOMAKE_VERSION= 1.16
AUTORECONF= ./autogen.sh
CONFIGURE_STYLE= autoreconf
-# upstream is doing something odd and doesn't add LDFLAGS/CXXFLAGS if CPPFLAGS
is set
-CONFIGURE_ENV= LDFLAGS="-L${LOCALBASE}/lib -L${X11BASE}/lib"
+
+CONFIGURE_ENV= LDFLAGS="-L${LOCALBASE}/lib -L${X11BASE}/lib" \
+ CPPFLAGS="-I${LOCALBASE}/include"
DEBUG_PACKAGES= ${BUILD_PACKAGES}
