On Fri, Sep 08, 2023 at 05:42:28PM +0000, Lucas Raab wrote:
> On Fri, Sep 08, 2023 at 05:30:45PM +0000, Brian Callahan wrote:
> > On 9/8/2023 1:28 PM, Anthony J. Bentley wrote:
> > > Lucas Raab writes:
> > >> Currently, devilutionx is broken on arm64 with an immediate crash.
> > >> Setting
> > >> USE_NOBTCFI=Yes allows it to run there and still compiles/runs on amd64
> > >> as
> > >> well.
> > >
> > > If amd64 works fine without it, maybe wrap the assignment in
> > > .if ${MACHINE_ARCH} == "aarch64"
> > > ?
> > >
> >
> > That was my request as well in Lucas's initial email to me.
> > He tells me that amd64 works (I can't test that myself right now).
> >
> > ~Brian
>
> oops, I made the change, but promptly forgot to update the diff. Now with 100%
> more changes...
> +.if ${MACHINE_ARCH} == "aarch64"
> +USE_NOBTCFI = Yes
USE_NOBTCFI-aarch64 = Yes
Would be great if both USE_NOBTCFI and USE_NOBTCFI-${MACHINE_ARCH}
could be documented.
> +.endif
> +
> MODULES = devel/cmake
>
> BUILD_DEPENDS = devel/asio \
