Hello, On 2023/04/04 18:29:08 -0300, Lucas de Sena <[email protected]> wrote: > Hi, > > This is a port for a program of mine, XFiles.
Happy to finally see a port for it! i've been using it since you
talked about it on #openbsd-gaming :)
> XFiles is a simple and configurable X11 file manager using Xlib and
> other Xenocara libraries in the base OpenBSD installation. It has no
> additional package as dependency.
>
> XFiles can be extended with x11/xmenu or x11/pmenu for adding context
> menus, and x11/dmenu for adding an URL bar for typing paths in.
>
> XFiles is pledged when built on OpenBSD.
some minor nits:
- REVISION starts empty, so omit it. If tweaked, it'll be set to 0
then incremented;
- I'd add the sysutil category too;
- HOMEPAGE is by default that when using GH_*;
- COMPILER / COMPILER_LANGS doesn't look wrong, but since you build
it with -std=c99 *I guess* base-gcc should handle it;
- style nit for MAKE_FLAGS: multiple values are generally one per line.
One thing that I could never make to work is dmenu: I have it
installed, but upon ctrl-g I get this error printed on the terminal
where I started xfiles:
X Error of failed request: BadMatch (invalid parameter attributes)
Major opcode of failed request: 62 (X_CopyArea)
Serial number of failed request: 69
Current serial number in output stream: 70
but this is not an issue with the port :)
I'm attaching a diff against your makefile and a fixed tarball that's
ok op@ to import.
P.S.: maybe, since xfiles(1) mentions xfilesctl and xfilesthumb we
could install them in /usr/local/bin and tell users to put their
own modified version in ~/bin if wanted. It'd be slightly more
user-friendly I guess.
Thanks!
Omar Polo
--- Makefile.orig Wed Apr 5 16:22:09 2023
+++ Makefile Wed Apr 5 16:23:28 2023
@@ -3,21 +3,16 @@
GH_ACCOUNT = phillbush
GH_PROJECT = xfiles
GH_TAGNAME = v1.0.1
-REVISION = 0
-CATEGORIES = x11
+CATEGORIES = x11 sysutils
-HOMEPAGE = https://github.com/phillbush/xfiles
-
# MIT
PERMIT_PACKAGE = Yes
-COMPILER = base-clang ports-gcc
-COMPILER_LANGS = c
-
WANTLIB += X11 Xcursor Xext Xft Xpm Xrender c fontconfig pthread
-MAKE_FLAGS = PREFIX=${PREFIX} MANPREFIX=${PREFIX}/man
+MAKE_FLAGS = PREFIX=${PREFIX} \
+ MANPREFIX=${PREFIX}/man
NO_TEST = Yes
xfiles.tar.gz
Description: GNU Zip compressed data
