Two things annoyed me in this otherwise useful plugin: - clicking it yields a cannot-execute-NetworkManager message (ENOPORT) - it allow using every interface, even though only atn0 is a wifi one
The command now defaults to the empty string and does nothing. The list of interfaces is now reduced to those with an IEEE80211 ifmedia(4) type, i.e. only proper wifi interfaces -- others make no sense in a WLAN tray plugin. Both have pending PRs upstream now which I'd like to apply. Feedback? OK? Index: Makefile =================================================================== RCS file: /cvs/ports/x11/xfce4/xfce4-wavelan/Makefile,v retrieving revision 1.51 diff -u -p -r1.51 Makefile --- Makefile 15 Dec 2022 14:51:03 -0000 1.51 +++ Makefile 22 Dec 2022 16:15:57 -0000 @@ -2,12 +2,23 @@ COMMENT= Xfce4 wireless interface monito XFCE_VERSION= 0.6.3 XFCE_PLUGIN= wavelan -REVISION= 2 +REVISION= 3 # BSD PERMIT_PACKAGE= Yes MODULES= x11/xfce4 + +MASTER_SITES0= https://gitlab.xfce.org/panel-plugins/xfce4-wavelan-plugin/-/ +# pending 'Default "Wifi Manager Command" to NetWorkManager only on Linux' +# https://gitlab.xfce.org/panel-plugins/xfce4-wavelan-plugin/-/merge_requests/11 +PATCHFILES+= wavelan-no-networkmanager-{commit/}cb806842.patch:0 +# pending 'Limit list of interfaces to IEEE 802.11 on OpenBSD and NetBSD' +# https://gitlab.xfce.org/panel-plugins/xfce4-wavelan-plugin/-/merge_requests/12 +PATCHFILES+= wavelan-ethernet-interfaces-only-{commit/}921b588c.patch:0 +PATCHFILES+= wavelan-ieee80211-interfaces-only-{commit/}c32e0b15.patch:0 + +PATCH_DIST_STRIP= -p1 WANTLIB += ICE SM X11 X11-xcb Xcomposite Xcursor Xdamage Xext Xfixes Xi WANTLIB += Xinerama Xrandr Xrender atk-1.0 atk-bridge-2.0 Index: distinfo =================================================================== RCS file: /cvs/ports/x11/xfce4/xfce4-wavelan/distinfo,v retrieving revision 1.13 diff -u -p -r1.13 distinfo --- distinfo 15 Jun 2022 06:25:25 -0000 1.13 +++ distinfo 22 Dec 2022 16:16:03 -0000 @@ -1,2 +1,8 @@ +SHA256 (xfce4/wavelan-ethernet-interfaces-only-921b588c.patch) = GC2UXJE8Mq8tiJmvwlbAFKv2HqtwV4sNuaSbKyJjH6c= +SHA256 (xfce4/wavelan-ieee80211-interfaces-only-c32e0b15.patch) = 8Kf9drumKC45kH5xZOAJxBsBrJ/QK4Lk1GTyPw+1h20= +SHA256 (xfce4/wavelan-no-networkmanager-cb806842.patch) = MUf8cPHQd9FT8Q6O/fpCNuvCjHAnstI3q+OhqAefBMI= SHA256 (xfce4/xfce4-wavelan-plugin-0.6.3.tar.bz2) = YcDC9Wy3CHLUA7dw3XY0nfn/JMDb6QXuG0+RPDTY9ys= +SIZE (xfce4/wavelan-ethernet-interfaces-only-921b588c.patch) = 1614 +SIZE (xfce4/wavelan-ieee80211-interfaces-only-c32e0b15.patch) = 2676 +SIZE (xfce4/wavelan-no-networkmanager-cb806842.patch) = 964 SIZE (xfce4/xfce4-wavelan-plugin-0.6.3.tar.bz2) = 364789
