On 2022/08/11 18:27, Nam Nguyen wrote:
> Stuart Henderson writes:
>
> > Don't roll your own "libtorrent.cpython-${MODPY_VERSION:C/\.//g}.so",
> > either use MODPY_PYC_MAGIC_TAG (as is used in the PLIST), or a
> > wildcard e.g. libtorrent*.so
>
> Thanks. Here is a fresh diff cribbed from thfr@'s games/gogrepo. I
> learned about about :S and :C from make(1). I used this to remove quotes
> from MODPY_PYC_MAGIC_TAG.
> + mv ${EGG}/libtorrent.${MODPY_PYC_MAGIC_TAG:S/"//g}so ${EGG}/..
No need to remove the quotes, the shell invoked by make doesn't mind
them anyway, so just this is enough (and I think probably better):
+ mv ${EGG}/libtorrent.${MODPY_PYC_MAGIC_TAG}so ${EGG}/..
otherwise OK
(I'm not sure why they're present in python.port.mk in the first place,
I'll do some tests and see if they can be removed..)
