Hello, Mikhail <[email protected]> wrote: > On Sat, May 28, 2022 at 04:58:59PM +0300, Mikhail wrote: > > On Sun, Apr 24, 2022 at 09:36:02PM +0300, Mikhail wrote: > > > Friendly weekly ping. > > > > New version 2.1.10 has been released, new port is attached. The > > developer has made changes, which allows to build epic5 with -O2, > > INSTALL document also updated, I've been testing this for several weeks > > and there were no crashes. > > 2.1.11 version is attached, also friendly weekly ping
some tweaks are needed:
- set PATCHORIG: currently there aren't patches, but there is a file
(scripts/reconnect.orig) which can cause issue if we ever need to
patch something here.
- the python flavors is missing `intl pthread util' as WANTLIB
- (nitpick/opinable) I'd drop COMMIT_ID: it's used in only one PLIST
entry and it's probably more work to sync it than accepting that every
update will have (at least) a one-line change to the plist.
- (nitpicking) pkg/README' box around the title should be 80 characters
long, as per README.template
- use ${TRUEPREFIX} in pkg/README, LOCALBASE is for "where other ports
are installed"
- is the MAINTAINER right? (sorry for the question but it's not the
email address you're using to ping, so...) it should be *your* email
address if you want to maintain it, otherwise drop it.
with these fixed (see diff against your makefile below and updated
tarball attached) it's ok op@ to import. (the maintainer is still to
fix)
one suggestion thought: what about adding a sample epicrc in
files/epicrc and installing it somewhere? Then the pkg/README could
just say 'copy ${TRUEPREFIX}/share/epic5/epicrc (or even
overwriting/extending upstream' epicrc.example with the OpenBSD-specific
stuff.)
(i don't really like how pledge and unveil are to be called from user
configuration by the way :/)
--- Makefile.orig Mon Jun 6 10:48:57 2022
+++ Makefile Mon Jun 6 10:57:55 2022
@@ -1,7 +1,6 @@
COMMENT= enhanced programmable ircII client 5th generation
VERSION= 2.1.11
-COMMIT_ID= 2071
DISTNAME= epic5-${VERSION}
CATEGORIES= net
HOMEPAGE= http://www.epicsol.org/
@@ -24,26 +23,21 @@
--without-python \
--without-libarchive
-# Developers suggest to have python flavor, because its support is
-# planned to evolve
FLAVORS= python
-
FLAVOR?=
+
.if ${FLAVOR:Mpython}
MODULES+= lang/python
CONFIGURE_ARGS+= --with-python
LIB_DEPENDS+= ${MODPY_LIB_DEPENDS}
-WANTLIB+= ${MODPY_WANTLIB}
+WANTLIB+= ${MODPY_WANTLIB} intl pthread util
.endif
-# Currently doesn't work because of some problems with 'stringify.c'
-#SEPARATE_BUILD= Yes
-
NO_TEST= Yes
-SUBST_VARS= COMMIT_ID
+# scripts/reconnect.orig
+PATCHORIG= .orig.port
-# UPDATES document contain info about recent changes and novelties
post-install:
${INSTALL_DATA_DIR} ${PREFIX}/share/doc/epic5/
${INSTALL_DATA} ${WRKSRC}/UPDATES ${PREFIX}/share/doc/epic5/
epic5.tar.gz
Description: GNU Zip compressed data
