On 2022/03/16 09:39, Bjorn Ketelaars wrote:
> On Wed 16/03/2022 06:56, Bjorn Ketelaars wrote:
> > I would like to import libdeflate [0], which is needed for future
> > releases of borgbackup (>1.3).
> > 
> > DESCR:
> > libdeflate is a library for fast, whole-buffer DEFLATE-based compression
> > and decompression.
> > 
> > Tests pass, and run tested in combination with borgbackup HEAD.
> > 
> > Comments / OK to import?
> > 
> > [0] https://github.com/ebiggers/libdeflate
> 
> Per sthen@ feedback:
> - add V=1 and CC="${CC}" to MAKE_FLAGS in Makefile
> - add CFLAGS to MAKE_FLAGS and add a patch stop overriding CFLAGS
> 
> New tarball enclosed.
> 
> OK?

I think we'd better keep some of the other flags, especially -std=c99
which IIRC isn't the default for base-gcc.

OK with this instead and getting rid of CFLAGS from MAKE_FLAGS 

-override CFLAGS :=                                                     \
-       -O2 -fomit-frame-pointer -std=c99 -I. -Wall -Wundef             \
+override CFLAGS :=                                                     \
+       -std=c99 -I. -Wall -Wundef              \

Reply via email to