On Sat, Feb 26, 2022 at 01:18:59PM +0000, Stuart Henderson wrote: > On 2022/02/26 12:55, Klemens Nanni wrote: > > This is a net/tdesktop dependency we currently build as bundle, but it > > telegram uses a forked version of rlottie with some slight changes, > is it really a good idea to change to this one?
Sticker themes would depend on those patches, but that isn't a big deal *imho*... to quote tdeskop's source: | "Application has been built with foreign rlottie, " | "animated emojis won't be colored to the selected pack."); Afterall, tdesktop allows `-D DESKTOP_APP_USE_PACKAGED_RLOTIE=ON` so I was inclined to make use of that in order to shrink down the tdesktop port as best as possible, since it does make maintaining/testing/fixing (on a slow machine) easier for me. > > > is a trivial port and might be useful to others > > does any other software actually use it? None that I am aware of at this point. Then again, rlottie upstream (Samsung) seems to have abandoned their rlottie libary in favour of yet another library[0], so I see little chances in upstreaming important fixes/patches from consumers like tdesktop. 0: https://gitter.im/rLottie-dev/community?at=612d940dd9a141754dc4bc3f "@/all hello guys, we gonna integrate rlottie with thorvg project." I'll defer this port and tdeskop's usage for now and see how things turn out, thanks for your input.
