On 2022/02/28 10:06, Omar Polo wrote: > I wasn't trying to say that we should patch the nim compiler to always > respect $CFLAGS, but rather that it should respect $CFLAGS *during the > build*. My patch had the side-effect of persisting the build-time > $CFLAGS as default compiler flags for the generated package too (they > end up in /etc/nim/nim.cfg), which now I think it's probably a good > idea. > > (the rationale is that the port infrastructure should be always able to > decide which CFLAGS to use and the port should respect that.)
agreed > Volker Schlecht <[email protected]> wrote: > > It uses fork instead of posix_spawn ... both OpenBSD and FreeBSD remove > > that line in their ports, though. NetBSD keeps it as it is. > > > > It was added by upstream 8 years ago, and the comment refers to > > posix_spawn being new to BSDs at the time. so that part of the patch can probably be garbage-collected now?
