On Fri, Feb 11, 2022 at 09:40:12PM -0700, Kurt Mosiejczuk wrote:
> http://build-failures.rhaalovely.net/sparc64/2022-02-09/multimedia/lebiniou.log
This log seems to contain two builds, one with base-gcc and one with
ports-gcc:
> ===> Compiler link: cc -> /usr/bin/cc
> ===> Compiler link: c++ -> /usr/bin/c++
> >>> Running configure in multimedia/lebiniou at 1644578989.70
This fails early:
> cc1: error: unrecognized command line option "-std=c11"
> ===> Compiler link: gcc -> /usr/local/bin/egcc
> ===> Compiler link: cc -> /usr/local/bin/egcc
> ===> Compiler link: c++ -> /usr/bin/c++
> >>> Running configure in multimedia/lebiniou at 1644589514.74
This fails late:
> cc -fPIE -fPIC -I/usr/local/include/ImageMagick -DMAGICKCORE_HDRI_ENABLE=0
> -DMAGICKCORE_QUANTUM_DEPTH=16 -fstack-protector-strong -Wformat
> -Werror=format-security -Wall -Werror -fomit-frame-pointer -std=c11
> -fsigned-char -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include
> -I/usr/local/include -O2 -pipe -pthread -Wl,-z,relro -Wl,-z,now -rdynamic -o
> lebiniou lebiniou-main.o lebiniou-cmdline.o lebiniou-signals.o
> lebiniou-bulfius_vui.o lebiniou-bulfius_vui_callback.o
> lebiniou-bulfius_get_colormap.o lebiniou-bulfius_get_image.o
> lebiniou-bulfius_get_frame.o lebiniou-bulfius_get_parameters.o
> lebiniou-bulfius_get_plugins.o lebiniou-bulfius_get_sequence.o
> lebiniou-bulfius_get_statistics.o lebiniou-bulfius_options.o
> lebiniou-bulfius_post_sequence.o lebiniou-bulfius_post_sequences.o
> lebiniou-bulfius_post_command.o lebiniou-bulfius_post_parameters.o
> lebiniou-bulfius_post_plugins.o lebiniou-bulfius_preview.o
> lebiniou-bulfius_vui_get_settings.o lebiniou-bulfius_vui_post_settings.o
> lebiniou-context_free_commands.o lebiniou-context_new_delete.o
> lebiniou-context_playlist.o lebiniou-image_8bits.o lebiniou-images.o
> lebiniou-options.o lebiniou-biniou.o lebiniou-circle.o lebiniou-context_run.o
> lebiniou-context_statistics.o lebiniou-scheme.o lebiniou-schemes.o
> lebiniou-schemes_str2option.o lebiniou-sequences.o lebiniou-commands.o
> lebiniou-bulfius_get_commands.o lebiniou-bulfius_str2command.o
> lebiniou-bulfius_command2str.o -L. -l:liblebiniou.so -L/usr/X11R6/lib
> -L/usr/local/lib -lMagickWand-6.Q16 -lMagickCore-6.Q16 -L/usr/local/lib
> -lulfius -lorcania -lyder -L/usr/local/lib -lorcania -L/usr/local/lib -lyder
> -lorcania -L/usr/local/lib -lglib-2.0 -lintl -L/usr/local/lib -ljansson -lm
> /usr/bin/ld: cannot find -l:liblebiniou.so
Confusingly, this builds fine on amd64:
> cc -fPIC -I../../../src -fstack-protector-strong -Wformat
> -Werror=format-security -Wall -Werror -fomit-frame-pointer -std=c11
> -fsigned-char -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include
> -I/usr/local/include -O2 -pipe -shared -fPIC -pthread -L../../../src
> -Wl,-z,relro -Wl,-z,now -rdynamic -o caca.so caca_so-caca.o -llebiniou
> -L/usr/local/lib -lcaca -L/usr/local/lib -lglib-2.0 -lintl -L/usr/local/lib
> -ljansson -lm
Which is interesting, since the it uses -liblebiniou rather than
-liblebniniou -- the src/Makefile.am (after our current patch) part that
decides this goes like
if OS_DARWIN
lebiniou_LDADD = -L. -llebiniou ${MAGICKWAND_LIBS} ${ULFIUS_LIBS}
${ORCANIA_LIBS} ${YDER_LIBS}
else
lebiniou_LDADD = -L. -l:liblebiniou.so ${MAGICKWAND_LIBS}
${ULFIUS_LIBS} ${ORCANIA_LIBS} ${YDER_LIBS}
endif
So is amd64 falling under OS_DARWIN here?
sparc64 definitely uses the latter, as can be confirmed by building with
the patch below which fixes the sparc64 build.
It seems correct and wrong at the same time...
Cc'ing the two involved in this new port.
Index: Makefile
===================================================================
RCS file: /cvs/ports/multimedia/lebiniou/Makefile,v
retrieving revision 1.2
diff -u -p -r1.2 Makefile
--- Makefile 9 Feb 2022 10:23:23 -0000 1.2
+++ Makefile 18 Feb 2022 18:11:39 -0000
@@ -5,6 +5,7 @@ COMMENT = music visualization & VJing to
PKGNAME = ${DISTNAME:S/-version//}
DISTNAME = lebiniou-${V}
V = version-3.65.0
+REVISION = 0
CATEGORIES = multimedia
@@ -19,6 +20,9 @@ WANTLIB += pthread pulse pulse-simple sn
WANTLIB += yder
MASTER_SITES = https://gitlab.com/lebiniou/lebiniou/-/archive/${V}/
+
+# -std=c11
+COMPILER = base-clang ports-gcc
RUN_DEPENDS += devel/desktop-file-utils \
x11/gtk+3,-guic
Index: patches/patch-src_Makefile_am
===================================================================
RCS file: /cvs/ports/multimedia/lebiniou/patches/patch-src_Makefile_am,v
retrieving revision 1.2
diff -u -p -r1.2 patch-src_Makefile_am
--- patches/patch-src_Makefile_am 9 Feb 2022 10:23:23 -0000 1.2
+++ patches/patch-src_Makefile_am 18 Feb 2022 18:11:49 -0000
@@ -52,7 +52,7 @@ Index: src/Makefile.am
lebiniou_LDADD = -L. -llebiniou ${MAGICKWAND_LIBS} ${ULFIUS_LIBS}
${ORCANIA_LIBS} ${YDER_LIBS}
else
-lebiniou_LDADD = -L. -l:liblebiniou.so.0 ${MAGICKWAND_LIBS} ${ULFIUS_LIBS}
${ORCANIA_LIBS} ${YDER_LIBS}
-+lebiniou_LDADD = -L. -l:liblebiniou.so ${MAGICKWAND_LIBS} ${ULFIUS_LIBS}
${ORCANIA_LIBS} ${YDER_LIBS}
++lebiniou_LDADD = -L. -lliblebiniou ${MAGICKWAND_LIBS} ${ULFIUS_LIBS}
${ORCANIA_LIBS} ${YDER_LIBS}
endif
commands.h: commands.h.head commands.c.in commands.h.tail commands_enum.awk