On Tue, Jan 11, 2022 at 10:22:33AM +0100, Landry Breuil wrote: > Le Mon, Jan 10, 2022 at 10:59:19PM +0100, Jeremie Courreges-Anglas a écrit : > > On Sun, Jan 09 2022, Theo Buehler <[email protected]> wrote: > > > pgadmin3 is one of the ports that I did not manage to fix for the > > > upcoming libcrypto bump. > > > > > > The problem is that it embeds a version of libssh2 old enough that it > > > wasn't converted to the OpenSSL 1.1 API. Patching this version is a > > > fool's errand. > > > > > > The diff below disables use of libcrypto and libssl. I don't know if > > > it makes sense to ship pgadmin3 without this, but given that configure > > > is prepared for it, it might. > > > > > > Someone motivated enough might manage to update that embedded libssh2. > > > I tried but I quickly gave up. > > > > Maybe that's a signal that maintaining this old pgadmin3 release isn't > > manageable any more. Upstream moved to pgadmin4 which is a completely > > different beast. > > > > pea@ gets the last word but I would suggest deleting it (ok jca@). > > Cleartext just sucks. > > sure, cleartext might sucks, but i always tunnel my cleartext psql cnx > over ssh so... i wouldnt have issues with non-ssl pgadmin :)
I figured that might be a common solution and that's why I sent this patch for consideration. > > cc'ing landry@ since he sowed interest in pgadmin too. > > i dont use it but think it's a pity to see it go. pgadmin4 is a monster, > so there were numerous pgadmin3 forks at the time, havent looked in > details but at least https://github.com/AbdulYadi/pgadmin3 and > https://github.com/Symbiatch/pgAdmin3; Both these seem to have the same issue of an outdated libssh2. I'm not saying it's impossible or even particularly hard to patch them to build and work. I stronlgy doubt that it's a good idea given that libssh2 had its share of issues over the years. So: if we want to keep pgadmin3 with libssh2 support, someone with an interest in this has to figure out how to link it against the libssh2 port or shoehorn in an update some other way. If there's libssl or libcrypto related issues with this I'll gladly help. > > at that point, someone interested in having a psql gui should port > http://sosedoff.github.io/pgweb/ and run it on localhost.. i think i > sent a port for https://github.com/Jet1oeil/opendbviewer a while ago but > it also seems not much alive upstream. > > Landry
