On 2021/12/28 20:29, Josh Grosse wrote:
> Attached is a diff to update from 3.14.1 to 4.3.
>
> Tested on amd64 only. This could use tests on
> on a gcc4 architecture -- if both gtk+3 and python 3.9
> are available -- as I am using an alternate
> PATCHDIR to modify a hard-coded "gcc" as the default
> compiler to "cc" on clang architectures only.
Please change these unconditionally i.e. for gcc archs too.
cc/c++ are still valid names in that case (and gcc/g++ aren't
really)..
> COMPILER = base-clang ports-gcc base-gcc
Build uses -std=c++17 so you can remove base-gcc.
It _ought_ to use CC/CXX from the environment and if that was not
difficult to do I'd ask for it, but looks like that is going to be a
pain with this port so we'll have to fallback to the cc/c++ symlinks in
${WRKDIR}/bin which are good enough.
> -MODPY_VERSION = ${MODPY_DEFAULT_VERSION_2}
\o/
>
> -LIB_DEPENDS = graphics/png
> +LIB_DEPENDS = graphics/png \
> + graphics/jpeg
>
> -RUN_DEPENDS = devel/desktop-file-utils \
> - misc/shared-mime-info \
> - x11/gnome/yelp \
> - x11/py-gtk2
> +RUN_DEPENDS += misc/shared-mime-info \
> + x11/gtk+3,-guic \
> + devel/desktop-file-utils
Removing py-gtk2 without a replacement rings alarm bells. Checking
the requirements list on https://github.com/fract4d/gnofract4d
it's going to want at least RDEP on py-gobject3 and py-cairo (with
${MODPY_FLAVOR}) and gtk+3 and BDEP on glib2 for glib-compile-resources.
> + if sys.platform[:6] == "darwin":
> +- cmd = "gcc -Wall -fPIC -DPIC -Ifract4d/c -shared %s -o %s -lm
> -flat_namespace -undefined suppress" % (
> ++ cmd = "cc -Wall -fPIC -DPIC -Ifract4d/c -shared %s -o %s -lm
> -flat_namespace -undefined suppress" % (
> + cFile.name, oFileName)
I would skip patching the darwin one, less chance of needing to merge
the patch in a future update.
