On 2021/12/20 00:13, Klemens Nanni wrote:
> On Mon, Dec 20, 2021 at 12:05:11AM +0100, Omar Polo wrote:
> > > # C++ devel/gtest
> > > COMPILER = base-clang ports-gcc
> >
> > I'm not sure what that means. At glance I can't really tell the minimum
> > C++ version this needs, but since you've tested on sparc64 (which is
> > a gcc arch IIRC) I assume it doesn't build with base gcc and thus it's
> > at least C++11.
>
> `make build' works on sparc64 with gcc 4.2.1 but `make test' builds
> against the gtest c++ headers and fails, hence the need for a newer
> compiler, but only due to tests.
Generally all C++ ports have to prefer ports-gcc over base-gcc to avoid
mixing incompatible C++ standard libraries on gcc archs. I don't think
you need to add an extra comment for that, other pprts do not do this
(only when setting COMPILER for non-C++ reasons).
> > pkg/PLIST:
> > > @so lib/libopenh264.so
> > > lib/libopenh264.so.0
> > > @lib lib/libopenh264.so.${LIBopenh264_VERSION}
> >
> > that doesn't look right, it should install only the last file. I
> > haven't found an obvious way to avoid that other than patching out a
> > couple of lines from the makefile.
Oh yes, good catch
> Yes, most ports ship a single file but we do have ports that contain
> symlinks, so I did not outright reject it.
The only one I can think of is librubyXX.so and that causes problems.
If there are others they are probably wrong too.
