On Tue, Dec 07, 2021 at 05:28:37AM -0700, [email protected] wrote:
> Bulk build on sparc64-0a.ports.openbsd.org
>
> Started : Sat Dec 4 15:08:37 MST 2021
> Finished: Tue Dec 7 05:28:00 MST 2021
> Duration: 2 Days 14 hours 19 minutes
>
> Built using OpenBSD 7.0-current (GENERIC.MP) #1083: Thu Dec 2 13:20:47 MST
> 2021
[...]
> http://build-failures.rhaalovely.net/sparc64/2021-12-04/games/vkquake.log
cc -DNDEBUG -c -O2 -pipe -std=c99 -Wall -Wno-trigraphs -Werror -std=gnu99
-fweb -frename-registers -DDO_USERDIRS=1 -DUSE_CODEC_WAVE -DUSE_CODEC_VORBIS
-DUSE_CODEC_MP3 -DLINUX -I/usr/local/include -I/usr/local/include/SDL2
-I/usr/X11R6/include -D_REENTRANT -I/usr/X11R6/include -o gl_draw.o gl_draw.c
cc1: warnings being treated as errors
gl_draw.c: In function 'Draw_PicFromWad2':
gl_draw.c:285: warning: array size (4) smaller than bound length (24)
I don't think this port needs -Werror. Diff below should let this build
on sparc64 again.
Planning to commit this if no concerns, or if I get an ok.
Index: Makefile
===================================================================
RCS file: /cvs/ports/games/vkquake/Makefile,v
retrieving revision 1.8
diff -u -p -r1.8 Makefile
--- Makefile 29 Nov 2021 06:40:43 -0000 1.8
+++ Makefile 10 Dec 2021 23:15:58 -0000
@@ -7,6 +7,7 @@ PKGNAME = vkquake-${V}
GH_ACCOUNT = Novum
GH_PROJECT = vkQuake
GH_TAGNAME = ${V}
+REVISION = 0
CATEGORIES = games x11
MAINTAINER = Thomas Frohwein <[email protected]>
Index: patches/patch-Quake_Makefile
===================================================================
RCS file: /cvs/ports/games/vkquake/patches/patch-Quake_Makefile,v
retrieving revision 1.3
diff -u -p -r1.3 patch-Quake_Makefile
--- patches/patch-Quake_Makefile 29 Nov 2021 06:40:43 -0000 1.3
+++ patches/patch-Quake_Makefile 10 Dec 2021 23:15:58 -0000
@@ -1,10 +1,20 @@
$OpenBSD: patch-Quake_Makefile,v 1.3 2021/11/29 06:40:43 thfr Exp $
remove hardcoded optimization flag
+remove -Werror (warnings on sparc64 build)
Index: Quake/Makefile
--- Quake/Makefile.orig
+++ Quake/Makefile
+@@ -48,7 +48,7 @@ STRIP ?= strip
+ CPUFLAGS=
+ DFLAGS ?=
+ CFLAGS ?=
+-CFLAGS += -Wall -Wno-trigraphs -Werror -std=gnu99
++CFLAGS += -Wall -Wno-trigraphs -std=gnu99
+ CFLAGS += $(CPUFLAGS)
+ ifneq ($(DEBUG),0)
+ DFLAGS += -D_DEBUG
@@ -56,7 +56,6 @@ CFLAGS += -g
do_strip=
else