Hello Yifei --
On 11/26/2021 9:52 AM, Yifei Zhan wrote:
> The following patch updates shells/elvish from v0.13.1 to v0.16.3 and
> fix build on arm64.
>
> highlights:
> - sync comment with upstream
> - use more accurate license marker
> - handle golang modules with MODGO_MODNAME and the new
> modules.inc
>
> Tested on amd64/arm64, examples on HOMEPAGE work fine.
>
I won't be able to build or run test this until later tonight, but a
couple of things inline.
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/shells/elvish/Makefile,v
> retrieving revision 1.7
> diff -u -r1.7 Makefile
> --- Makefile 8 Mar 2021 13:59:26 -0000 1.7
> +++ Makefile 26 Nov 2021 13:59:31 -0000
> @@ -1,25 +1,25 @@
> # $OpenBSD: Makefile,v 1.7 2021/03/08 13:59:26 sthen Exp $
>
> -BROKEN-aarch64 = looks like the vendored golang.org/x/sys/unix is too old
> for aarch64
> -# try removing above with next update
> -
> ONLY_FOR_ARCHS = ${GO_ARCHS}
>
> -COMMENT = cross-platform, friendly, and expressive shell
> +COMMENT = Expressive programming language and versatile shell
Please don't capitalize the first letter of the comment unless it is a
proper noun.
> CATEGORIES = shells
>
> GH_ACCOUNT = elves
> GH_PROJECT = elvish
> -GH_TAGNAME = v0.13.1
> -REVISION = 0
> +GH_TAGNAME = v0.16.3
>
> HOMEPAGE = https://elv.sh/
> MAINTAINER = Brian Callahan <[email protected]>
> -# BSD
> +
> +# BSD 2-Clause "Simplified" License
Unless something has changed very recently, we don't usually
over-specify BSD licenses. What is there now is fine.
> PERMIT_PACKAGE = Yes
>
> -WANTLIB += c pthread
> +WANTLIB += c pthread
This line didn't change. Please don't churn for the sake of churn.
> +
> +MODULES = lang/go
>
> -MODULES = lang/go
Ditto here.
The rest I'll check later when I can build and run test this.
Thanks.
~Brian
