Hi Jasper, hi Steven, hi Wijnand,
Jasper Lievisse Adriaanse wrote on Sun, Apr 29, 2007 at 12:04:40PM +0200:
> i made some more modifications:
> - SUBST_VARS isn't needed
I fear you broke it. The bsd.port.mk fake target does not work as it
should and the post-install target fails for me. The reason is that
the jabber configuration files now get installed to ${WRKINST}/etc/
instead of ${WRKINST}/etc/jabberd14, thus crashing the command
mv jabber.xml jabber.mysql.xml
during post-install. I dimly remember some trouble i had in the
very beginning of setting up the port, telling ${WRKSRC}/Makefile
about ${SYSCONFDIR}/jabberd14. In your version of the port, this
problem is back: $(sysconfdir) in ${WRKSRC}/Makefile again is /etc
and not /etc/jabberd14 as it should.
Besides, the port Makefile contains
J_CONFDIR= ${SYSCONFDIR}/jabberd14
and related instrumentation to put jabber config files in there.
Yet, ${PKGDIR}/PLIST has
@sample ${SYSCONFDIR}/jabber.xml # and two similar lines
This does not look consistent.
There may be an additional problem with ${PKGDIR}/PLIST. It still
contains
@newgroup _jabberd14:585
@newuser _jabberd14:585:585:daemon:Jabber Server: [...]
Do not forget to adjust the UID/GID at commit time.
> - don't hardcode paths in README.OpenBSD
> - better MESSAGE
This looks good.
> with this diff, it looks ok to me.
> steven, ok with you too?
> http://humppa.nl/~jasper/jabberd14.tgz
I hate saying that, but seeing all those commit messages saying
"Use xenocara expat" and having LIB_DEPENDS+= expat::textproc/expat
in this port, i think i ought to update the port to use xenocara
expat, too.
I will look into these points as soon as i find time, hopefully
this evening.
Thanks for all your help with the port,
Ingo
