On Mon, Nov 08, 2021 at 04:54:49PM +0100, Theo Buehler wrote:
> One pain point with the cargo module is 'make update-patches'. The
> problem is that crates.io normalizes the Cargo.toml files to maximize
> compatibility with all versions of Cargo and to use crates.io paths for
> dependencies. All DISTFILES in ${DISTFILES}/cargo contain both a
> Cargo.toml and Cargo.toml.orig, which cripples 'make update-patches'
> unless PATCHORIG is set. For this reason, about a third of the Rust
> ports set the PATCHORIG variable (all of them unconditionally).
>
> I suggest that we add a PATCHORIG ?= line to cargo.port.mk. This way,
> the user setting in /etc/mk.conf is respected and not overridden by the
> port Makefiles. The majority set PATCHORIG = .openbsd.orig, so I chose
> that as a default. The diff below also removes all PATCHORIG lines from
> the cargo ports.
I think we already had this discussion before.
https://marc.info/?l=openbsd-ports&m=162755871931464&w=2 - PATCHORIG default
(was Re: cargo.port.mk: remove Cargo.toml.orig from crates)
PATCHORIG is a setting for a port. For me, a module shouldn't set it.
The default (in bsd.port.mk) of '.orig' might be better to be changed
instead of, even if it means adaptation for people with scripts for
editing ports.
Currently, we have ~50 ports with a specific value of PATCHORIG.
Thanks.
--
Sebastien Marie
