On 2021/09/16 14:46, Sergey A. Osokin wrote:
> Hi,
>
> kindly reminder.
> Please let me know if you have any questions.
>
> Thank you.
>
> On Tue, Sep 07, 2021 at 12:56:03PM +0000, Sergey A. Osokin wrote:
> > Hi there,
> >
> > I'm glad to share with you NGINX Unit port for OpenBSD has been created.
> >
> > In addition to the port (it's been attached to this email as a tarball)
> > an additional user account `unit' and `unit' group are need to be created.
> >
> > Please let me know your thoughts, ask questions, provide comments.
>
> --
> Sergey Osokin
>From a read through (I have not tried building yet):
- usernames for ports daemons should be prefixed by _ and must be
created in the PLIST (@newuser / @newgroup annotations)
- the subpackages should just set PREFIX-python etc, don't use @cwd in
their PLISTs
- lowercase at the start of COMMENT, unless it's a proper noun, i.e.
s/Dynamic/dynamic/ in COMMENT-main
- "include bsd.port.arch.mk" should be later. specifically it needs to go
after the FLAVOR ?=, but as it has hard to predict side-effects it's
better to have as few parts after it as possible, I would move to just
before the ".if ${BUILD_PACKAGES..." lines as those are the only parts
which require it.
- drop "DISTFILES=${DISTNAME}${EXTRACT_SUFX}", that is the default
- separate line for each *_DEPENDS entry i.e. change
RUN_DEPENDS-python= www/unit,-main ${MODPY_LIB_DEPENDS}
to
RUN_DEPENDS-python= www/unit,-main \
${MODPY_LIB_DEPENDS}
- there are specific variables for the binaries for python/ruby:
${MODPY_BIN} and ${RUBY}, unless the configure script really doesn't
want a path please use them rather than building up your own in
CONFIGURE_ENV ${RUBY}
