On 2021/09/12 14:41, Stuart Henderson wrote:
> - please merge the ".if ${BUILD_PACKAGES:M-python}" blocks
>
> - the BUILD_DEPENDS on lang/python is set automatically by the python module
> and shouldn't be listed separately
>
> - ${BUILD_PKGPATH}-main=${V} should be ${BUILD_PKGPATH},-main=${V}
> (the , is missing), but a LIB_DEPENDS entry is only valid if there is a
> WANTLIB referencing a library from the dependency, so either a WANTLIB
> entry is missing or it should be a RUN_DEPENDS (i didn't build-test;
> run "make port-lib-depends-check" and add the WANTLIB if it complains)
>
> - post-install should not hardcode /usr/local. I think you should probably
> use "${MODPY_BIN} setup.py ${MODPY_DISTUTILS_INSTALL}" here.
>
> - pkg/PLIST-main requires "@pkgpath textproc/libmarisa" otherwise the new
> subpackage won't be considered by pkg_add as an update for the old
> "non-subpackaged" version
>
..also it needs "REVISION-main=0"
