On 21-08-25 23:13:37, Stuart Henderson wrote:
> On 2021/08/24 16:13, Aaron Bieber wrote:
> > On Wed, 25 Aug 2021 at 04:10:43 +1000, Joel Sing wrote:
> > > The below diff updates lang/go to Go 1.17.
> > >
> > > Tested on amd64 and arm64, still need to retest on arm, i386 and mips64.
> > >
> > > ok?
> > >
> >
> > Mini-bulk finished:
> >
> > Elapsed time=02:26:32
> > I=433 B=10 Q=0 T=105 F=0 !=1
> > E=net/termshark math/blas textproc/py-stemmer,python3
> >
> > I was surprised by the termshark failure!:
>
> It did that with earlier go too, but the workaround in do-build was enough
> before.
If I roll back to 20210601, net/termshark builds fine with Go 1.17, so it
appears
to be something that has changed more recently, combined with Go 1.17. There is
a new copy of pty_openbsd.go in a different package which is seemingly now
triggering
the issue - removing that file results in other problems :)
> > github.com/pkg/term/termios
> > github.com/gcla/termshark/v2/tty
> > github.com/kr/pty
> > # github.com/kr/pty
> >
> > ../../../../go/pkg/mod/github.com/creack/pty@v1.1.14/pty_openbsd.go:27:10:
> > undefined: ptmget
> >
> > ../../../../go/pkg/mod/github.com/creack/pty@v1.1.14/pty_openbsd.go:28:34:
> > undefined: ioctl_PTMGET
> > *** Error 2 in net/termshark (Makefile:31 'do-build')
> > *** Error 2 in net/termshark
> > (/usr/ports/infrastructure/mk/bsd.port.mk:2943
> > '/tmp/pobj/termshark-2.2.0/build-amd64/.build_done': @cd /usr/po...)
> > *** Error 2 in net/termshark
> > (/usr/ports/infrastructure/mk/bsd.port.mk:2602 'build':
> > @lock=termshark-2.2.0p1; export _LOCKS_HELD=" termshar...)
> > ===> Exiting net/termshark with an error
> > *** Error 1 in /usr/ports (infrastructure/mk/bsd.port.subdir.mk:137
> > 'build': @: ${echo_msg:=echo}; : ${target:=build}; for i in ; do eval...)
> > >>> Ended at 1629838835.67
> > max_stuck=7.22/clean=0.61/patch=12.36/configure=4.54/build=289.29
> > Error: job failed with 512 on localhost at 1629838835
> >
> > Everything else looks fine to me (I have been using a similar diff to test
> > if
> > the lazy module stuff changes portgen)!
> >
> > OK abieber@ if the other arches build :D
