Hi Marc, Marc Espie wrote on Wed, Apr 11, 2007 at 09:30:28AM +0200: > the idea is fine, don't worry about the polishing, I'll refactor it > a bit to avoid having so much code in there.
Great, thanks, so i'll just wait and see. Tell me when i can help with anything (e.g., testing). > - using p5-Text-Diff is not such a good idea, we tend to prefer > keeping pkg_add entirely in base. I thought p5-Text-Diff could be imported into base, like many other perl modules, but that's perhaps overkill. What you are proposing below is certainly less invasive. > - you don't want to use system, but get a pipe opened to a diff > command. That way, you don't need a temporary file. > - read about the list-based versions of diff and open. > They are necessary for anything security-related. Sounds good; like that, as a side benefit, you can easily avoid writing empty diffs - which my first version of the patch still does. Looking forward to learning how you are going to do it, Ingo
