On 4/19/21 9:45 PM, Peter Piwowarski wrote:
games/nethack had its -qt flavor removed some time back when Qt3 went
away; upstream has however ported the Qt window port to Qt4/Qt5 in
3.6.x. This is a rough stab at trying to add a -qt flavor back for
version 3.6 only, built against Qt5. Some notes:

* Paradoxically, this involves removing both Qt-specific patches that
   are still floating around. patch-win_Qt_qt_win.cpp applies, so far as
   I can tell, to the old Qt3 code, and is no longer pertinent (and in
   fact the patch was going to break with 3.7), and the local copy of
   qt_xpms.h differs from upstream's only in a way that breaks the build
   (it's missing one pixmap).
* I've added a README explaining both how to switch between interfaces
   and noting a few options upstream documentation recommends setting for
   use with Qt. If desired I can generate another diff without this.

~patch snipped~

Bump. I've been using this locally for the past month-and-a-bit. It has a few upstream bugs the Qt3 version didn't, enough that I've had to use recover several times; whether that's enough reason on its own to leave it disabled I don't know. One is sufficiently reproducible that I might be able to track it down and provide a patch at some future date.

Reply via email to