On Sun, May 02 2021, Aisha Tammy <[email protected]> wrote: > Hi, > > I've attached an update to lmdb to latest, all tests are passing.
Thanks, but the patch doesn't apply. No need to resend, though. I have not looked in depth, but I have questions: - this changes MASTER_SITES. Do you have a good reason except for 0.9.29 being seemingly available at the new MASTER_SITES (github only has 0.9.28, maybe an oversight?) - for ports which provide libraries, any time you update you must check whether no bump, a minor or a major bump is needed. More details on http://www.openbsd.org/faq/ports/specialtopics.html#SharedLibs > OK? oks mostly make sense when you intend to commit something yourself. ;) > Best, > Aisha > > > diff --git a/databases/lmdb/Makefile b/databases/lmdb/Makefile > index 7d110399173..f933a977e79 100644 > --- a/databases/lmdb/Makefile > +++ b/databases/lmdb/Makefile > @@ -2,15 +2,14 @@ > COMMENT = Symas Lightning Memory-Mapped Database > -VERSION = 0.9.24 > +VERSION = 0.9.29 > -GH_ACCOUNT = LMDB > -GH_PROJECT = lmdb > -GH_TAGNAME = LMDB_${VERSION} > +PKGNAME = lmdb-${VERSION} > +DISTNAME = openldap-LMDB_${VERSION} > -DISTNAME = ${GH_PROJECT}-${VERSION} > +MASTER_SITES = > https://git.openldap.org/openldap/openldap/-/archive/LMDB_${VERSION}/ > -SHARED_LIBS += lmdb 0.0 # 0.0 > +SHARED_LIBS += lmdb 0.0 # 0.0 > CATEGORIES = databases > @@ -31,6 +30,6 @@ MAKE_FLAGS = CC="${CC}" XCFLAGS="${CFLAGS}" \ > SHARED_VERSION_MAJOR=${LIBlmdb_VERSION:R} \ > SHARED_VERSION_MINOR=${LIBlmdb_VERSION:E} > -WRKDIST = ${WRKDIR}/lmdb-${GH_TAGNAME}/libraries/liblmdb > +WRKDIST = ${WRKDIR}/openldap-LMDB_${VERSION}/libraries/liblmdb > .include <bsd.port.mk> > diff --git a/databases/lmdb/distinfo b/databases/lmdb/distinfo > index b66ab20b0e7..58dc82d354a 100644 > --- a/databases/lmdb/distinfo > +++ b/databases/lmdb/distinfo > @@ -1,2 +1,2 @@ > -SHA256 (lmdb-0.9.24.tar.gz) = RGAkNsUsKdTzAfVfb9gRX5RUabhoNI483a+RqyRz6iY= > -SIZE (lmdb-0.9.24.tar.gz) = 143916 > +SHA256 (openldap-LMDB_0.9.29.tar.gz) = > 1MZoFnotcD75HbcztAabi3Tbw3RAWFW+Zia0Xip+LdM= > +SIZE (openldap-LMDB_0.9.29.tar.gz) = 144545 > diff --git a/databases/lmdb/patches/patch-mdb_c > b/databases/lmdb/patches/patch-mdb_c > index e8bf2dc8687..29df2cf615f 100644 > --- a/databases/lmdb/patches/patch-mdb_c > +++ b/databases/lmdb/patches/patch-mdb_c > @@ -5,7 +5,7 @@ enforce MDB_WRITEMAP, because we have no UBC (Unified Buffer > Cache). > Index: mdb.c > --- mdb.c.orig > +++ mdb.c > -@@ -4968,6 +4967,7 @@ mdb_env_open(MDB_env *env, const char *path, unsigned > +@@ -4976,6 +4976,7 @@ mdb_env_open(MDB_env *env, const char *path, unsigned > /* silently ignore WRITEMAP when we're only getting read access > */ > flags &= ~MDB_WRITEMAP; > } else { > -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
