On Thu, Mar 04, 2021 at 04:35:43PM +0100, Michael wrote:
> On Thu, Mar 04, 2021 at 04:26:17PM +0100, Landry Breuil wrote:
> > On Thu, Mar 04, 2021 at 04:15:57PM +0100, Michael wrote:
> > > On Thu, Mar 04, 2021 at 04:03:38PM +0100, Landry Breuil wrote:
> > > > On Thu, Mar 04, 2021 at 03:14:42PM +0100, Michael wrote:
> > > > > > 
> > > > > > and looking again a bit closer, gdal support was removed in
> > > > > > https://github.com/Xastir/Xastir/pull/48 so gdal can go away from 
> > > > > > the
> > > > > > depends.
> > > > > > 
> > > > > > xastir-2.1.6(comms/xastir):
> > > > > > Extra:  gdal.40 iconv.7
> > > > > > 
> > > > > > the fact that it thinks iconv is extra is probably due to you 
> > > > > > removal of
> > > > > > configure.ac patch, which was here since the import and adding 
> > > > > > AC_CHECK_LIB(iconv, libiconv_open, LIBS="-liconv ${LIBS}")
> > > > > > 
> > > > > > can you also recheck if intl/iconv support works fine without this
> > > > > > dependency ?
> > > > > > 
> > > > > > Landry
> > > > > 
> > > > > I hope I was able to follow you. Xastir still builds and runs fine 
> > > > > with 
> > > > > iconv and gdal removed from the port. Not sure if that is relevant or 
> > > > > not but switching to different languages also still works and Umlauts 
> > > > > etc. work too. For the record: with proj-7.2.1.
> > > > > Diff below.
> > > > 
> > > > yeah sorry, i'm sometimes looking at 10 different things at the same
> > > > time.
> > > > 
> > > > what i meant was since https://github.com/Xastir/Xastir/pull/48 geo/gdal
> > > > can be removed from LIB_DEPENDS and WANTLIB, and with the removal of
> > > > patch-configure_ac iconv should also be removed from WANTLIB, apparently
> > > 
> > > I think I got that right then, see my pervious diff. :)
> > 
> > im confused then, because that diff only have the removal of intl from
> > WANTLIB.. not gdal/iconv, and no change on LIB_DEPENDS ?
> 
> Yikes, my bad. Got confused with the patch files. 
> Correct one below:

Thanks, commited this one, and backported the commit to fix proj8
detection on top !

Landry

Reply via email to