On Tue Feb 16, 2021 at 05:13:15PM -0500, Daniel Dickman wrote:
>
>
> > On Feb 16, 2021, at 4:57 PM, Stuart Henderson <[email protected]> wrote:
> >
> > On 2021/02/16 21:50, Rafael Sadowski wrote:
> >>> On Tue Feb 16, 2021 at 04:42:07PM +0000, Stuart Henderson wrote:
> >>> On 2021/02/15 14:02, Daniel Dickman wrote:
> >>>>
> >>>>
> >>>> On Mon, 15 Feb 2021, Rafael Sadowski wrote:
> >>>>
> >>>>> Please find attached a new dependency for an possible calibre update.
> >>>>>
> >>>>
> >>>> I think it needs dependencies on at least:
> >>>> - py-lxml
> >>>> - py-chardet
> >>>> - py-beautifulsoup4
> >>>
> >>> beautifulsoup4 is optional. I wonder why portgen doesn't notice
> >>> lxml/chardet.
> >>>
> >>>> maybe more things too, but that's as far as I got.
> >>>
> >>> there are forced -O3 in the C compiles.
> >>>
> >>
> >> Thanks for your feedback. New attempt attached with the following
> >> changes:
> >>
> >> - Remove 03 opts
> >> - Added HOMEPAGE
> >> - Added the following depends:
> >>
> >> BUILD_DEPENDS = textproc/py-chardet${MODPY_FLAVOR} \
> >> textproc/py-lxml${MODPY_FLAVOR} \
> >> www/py-beautifulsoup4${MODPY_FLAVOR}
> >>
> >> RUN_DEPENDS = www/py-beautifulsoup4${MODPY_FLAVOR}
> >
> > beautifulsoup4 is an optional run dependency.
> > py-lxml and py-chardet are required run depencies.
> > None of them are needed at build time.
>
> bs4 should be a TDEP.
>
>
> >
Thanks. I'm not familiar with extras_require,install_requires and the
whole python setup. OK with this dependencies?
LIB_DEPENDS = textproc/libxml
RUN_DEPENDS = textproc/py-chardet${MODPY_FLAVOR} \
textproc/py-lxml${MODPY_FLAVOR}
TEST_DEPENDS = www/py-beautifulsoup4${MODPY_FLAVOR}