On 2021/02/03 13:35, Mark Kettenis wrote:
> Doing some $DAYJOB work on my OpenBSD laptop which requires the
> astropy package. This really is a widely used toolkit that is
> actively maintained.
>
> This diff is based on a diff sent to ports@ some time ago by Wen
> Heping. I just updated it to version 4.0.4, which is the latest "LTS"
> release. Not sure what to do with the MAINTAINER field. If Wen is
> willing to maintain this port that's fine with me. But I could take
> over.
>
> ok?
small tweaks;
> Index: astro/py-astropy/Makefile
> ===================================================================
> RCS file: astro/py-astropy/Makefile
> diff -N astro/py-astropy/Makefile
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ astro/py-astropy/Makefile 3 Feb 2021 11:22:22 -0000
> @@ -0,0 +1,30 @@
> +# $OpenBSD$
> +
> +COMMENT = Community-developed python astronomy tools
ports standard is to lowercase start of COMMENT,
s/Community/community
> +
> +MODPY_EGG_VERSION = 4.0.4
> +
> +DISTNAME = astropy-${MODPY_EGG_VERSION}
> +PKGNAME = py-${DISTNAME}
> +
> +CATEGORIES = astro
> +
> +HOMEPAGE = http://astropy.org
> +
> +MAINTAINER = Wen Heping <[email protected]>
> +
> +# BSD license
> +PERMIT_PACKAGE = Yes
> +
> +MODULES = lang/python
> +
> +MODPY_PI = Yes
> +MODPY_SETUPTOOLS = Yes
> +MODPY_VERSION = ${MODPY_DEFAULT_VERSION_3}
Please replace the above MODPY_VERSION line with
FLAVORS = python3
FLAVOR = python3
otherwise things get confusing if any other ports end up depending on
this.
> diff -N astro/py-astropy/pkg/PLIST
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ astro/py-astropy/pkg/PLIST 3 Feb 2021 11:22:22 -0000
> @@ -0,0 +1,2133 @@
> +@comment $OpenBSD: PLIST,v$
> +bin/fits2bitmap
> +bin/fitscheck
> +bin/fitsdiff
> +bin/fitsheader
> +bin/fitsinfo
> +bin/samp_hub
> +bin/showtable
bin/showtable conflicts with devel/p5-Data-ShowTable. Either rename it,
e.g.
post-install:
mv ${PREFIX}/bin/showtable ${PREFIX}/bin/showtable.astropy
or register the conflict; to do that, add to astropy's PLIST:
@conflict p5-Data-ShowTable-*
and similarly on the other side in devel/p5-Data-ShowTable, bump REVISION
in the Makefile and add to PLIST:
@conflict py3-astropy-*
p5-Data-ShowTable is a leaf port so I can't imagine there being any major
problems from adding the conflict.
Rest is OK with me.
