Hi Aaron,
Aaron Poffenberger writes:
> SWORD is a cli app from the CrossWire project for viewing Biblical
> texts from the command line. It also includes the library used by GUI
> apps.
Thanks, good program to have in-tree. A few things need to be fixed:
- according to Makefile.template COMPILER should be
"base-clang ports-gcc base-gcc"
- libsword.so needs to end in a version number (specifically
${LIBsword_VERSION} which is 0.0). ditto for libsword-1.9.0.so
- license comment should be "GPLv2 only"
- AUTORECONF doesn't appear to be necessary
- COMMENT should not end in a period
- is -DU_USING_ICU_NAMESPACE=1 still needed? if not it should be removed,
if so it should have a comment explaining why it's there
- remove NO_TEST, "make test" succeeds (even though it runs zero tests,
they may add more in the future)
And some not very important things, to make it look more like other ports:
- please reorder lines to match Makefile.template
- don't indent WANTLIB, most people copy and paste port-lib-depends-check
output there
- one LIB_DEPENDS per line, using = and backslashes instead of +=
- switch homepage and master_sites to https
--
Anthony J. Bentley
