On Mon, Jul 31, 2006 at 12:05:14AM +0200, steven mestdagh wrote:
> Jon Olsson [2006-07-30, 18:38:09]:
> > Please test and commit this update before the ports freeze, it fixes som
> > man page issues in the current package.
> > 
> > Tested on 4.0-beta i386. 
> > -- 
> > Jon
> 
> > Update of the Erlang port from 10B-10 to 11B-0
> > 
> > Change highlights in R11B:
> > * SMP enabled runtime
> > * Dialyzer included by default (code analyzer)
> > 
> > Port changes
> > * version number format from 11B_0 -> 11b.0
> > * don't use @man for man pages, since we don't install 
> >   the manpages in the regular man directories. 
> >     erl -man manpage is the erlang way
> 
> we have @mandir for this, so we can stick with the unix way as well,
> and you won't need to remove all those @man instances.

Alright, I'll send an update tomorrow with a new diff that incorporates
all the changes discussed in this mail.

> 
> > +--- erts/emulator/utils/beam_makeops.orig  Wed May  3 10:01:25 2006
> > ++++ erts/emulator/utils/beam_makeops       Fri Jul 28 20:14:37 2006
> > +@@ -481,7 +481,7 @@ sub emulator_output {
> > +     print "\n";
> > +     print "#ifdef ARCH_64\n";
> > +     print "#  define BEAM_LOOSE_MASK 0x1FFFUL\n";
> > +-    print "#  define BEAM_TIGHT_MASK 0xFFCUL\n";
> > ++    print "#  define BEAM_TIGHT_MASK 0x1FF8UL\n";
> 
> can you explain this?

It's a bugfix, discussion:
http://www.erlang.org/ml-archive/erlang-questions/200606/msg00425.html

> 
> > +--- lib/ssh/src/ssh_sftp.erl.orig  Thu May  4 16:46:39 2006
> > ++++ lib/ssh/src/ssh_sftp.erl       Fri Jul 28 20:14:38 2006
> > +@@ -283,8 +283,10 @@ init([CM]) ->
> > +       {stop, Error }
> > +     end;
> > + init([Host,Port,Opts]) ->
> > ++    SaveFlag = process_flag(trap_exit, true),
> > +     case ssh_xfer:connect(Host, Port, Opts) of
> > +   {ok, Xf, RBuf} ->
> > ++      process_flag(trap_exit, SaveFlag),
> > +       {ok, #state { req_id = 0, xf = Xf, rep_buf=RBuf }};
> > +   Error ->
> > +       {stop, Error}
> 
> and this

Another bugfix, as stated in the patch file itself:
"Bugfix: ssh_sftp:connect/2,3 hangs when the remote host is unknown."
>From FreeBSD

> [PLIST]
> >  lib/erlang/man/
> 
> so this is where we should put @mandir lib/erlang/man/

Ok.

> 
> >  lib/erlang/usr/include/
> >  lib/erlang/usr/include/driver_int.h
> >  lib/erlang/usr/include/erl_driver.h
> > +lib/erlang/usr/include/erl_fixed_size_int_types.h
> > +lib/erlang/usr/include/erl_int_sizes_config.h
> > +lib/erlang/usr/include/erl_memory_trace_parser.h
> >  lib/erlang/usr/include/obsolete/
> >  lib/erlang/usr/include/obsolete/driver.h
> >  lib/erlang/usr/lib/
> > [EMAIL PROTECTED] /bin/rm -f %D/lib/erlang/man/whatis.db
> > +lib/erlang/usr/lib/liberts.a
> > +lib/erlang/usr/lib/liberts_r.a
> 
> those /usr/lib and /usr/include under lib/erlang look really weird...
> i guess that is the erlang way again?

Hmm, I guess something funky is going on there, I'll look into it.

> builds okay on amd64, but i think you should try removing -O3 again in
> a few places.

Will do.

> oh, please remove the last line from DESCR, and set HOMEPAGE.

Will do.

Regards,
-- 
Jon

Reply via email to