Michael Knudsen <[EMAIL PROTECTED]> wrote:
> New version attached.
DESCR doesn't quite make sense. Surely somebody who installs the
package is not concerned with hypothetical compile time options.
Gmake isn't really required. Just remove the mistaken $< dependency for
the .c.o suffix rule in src/Makefile.in.
When adding preprocessor options, such as include paths, for the
benefit of a GNU configure script, use CPPFLAGS rather than CFLAGS.
Makefiles written according to GNU autotools standards will have a
replacement like
CFLAGS = @CFLAGS@ @CPPFLAGS@
If a Makefile fails to pick up CPPFLAGS, add it.
Your patch-src_Makefile_in should not be necessary. If configure
fails to substitute the desired values there, you probably should
fix configure.
Rather than kludging -lz -lm for png into LDFLAGS, try expanding the
corresponding AC_CHECK_LIB call in configure.in by the fifth "other
libs" argument. (See the autoconf docs on the AC_CHECK_LIB macro.)
Switch the port to CONFIGURE_STYLE=autoconf and don't forget to
specify AUTOCONF_VERSION. -L${LOCALBASE}/lib in LDFLAGS is fine.
Use the current major version of the respective libs in LIB_DEPENDS.
--
Christian "naddy" Weisgerber [EMAIL PROTECTED]
