Daniel Engberg <dii...@freebsd.org> wrote: > On 2025-02-28 22:32, Michael Grimm wrote:
> Upstream is releasing new versions twice a year, January and July. I made > some contributions to logwatch which have been accepted immediately after the > last release in January in order to give some time for testing by the > logwatch team members. > > This is my question: Would it be a no-go if I would patch the current release > w.r.t the upcoming release in July this year? > > Benefit would be: > > #) Ability to deal with FBSD's 'syslogd -v' <facility.severity> patterns in > logfiles if activated [1] > #) Discard dependency of a perl module, namely HTML::HTML5::Entities [2] > #) Improvement of the dovecot script [3] > #) Plus some other minor modifications > > [1] > https://sourceforge.net/p/logwatch/git/ci/85f3b99d78b7dda81b00d252fbd2ff6c4f430ec9/ > [2] > https://sourceforge.net/p/logwatch/git/ci/42e949949e90980acfe3d9c5c9a46ecfe73b2df1/ > [3] > https://sourceforge.net/p/logwatch/git/ci/5072cff136957bcdb7228d707d97a8c5377896d4/ > >> BTW: Would someone capable of committing PR 285078, just a simple bug fix >> [4]? >> Very much appreciated. >> [4] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=285078 Can someone commit this simple bugfix for missing some files in pkg-plist and files/Makefile, please? Thanks in advance. > Maintainers are given relatively "free hands" however the general > encouragement is not to diverge from upstream if possible. > Having local patches (especially many) significantly increases maintenance > burden as they tend to break when upstream releases a new version. If > patching is desired/required try to be as verbose as possible as to why and > origin, and always try to upstream as much as possible. Unfortunately a > common reason as to why ports gets stick to a specific version is when there > are lots of patches with lacking documentation and/or not upstreamed changes. > In your specific case I don't see why it would be seen as an issue given that > you've provided documentation and the fact that they're backports from > upstream (thanks for submitting these changes upstream). > Thanks for adopting sysutils/logwatch ! Thanks for your feedback on that. I will most likely prepare patches for the most important fixes already accepted upstream (see above). But first I do want to get the pending bugfix committed ;-) Regards, Michael
