On Tue, 28 Jan 2025, s...@triumf.ca wrote:
> FWIW, after a bit of effort, I managed to make wine compile and run
> without the gcc dependency (which, when installed, can mess other
> ports up during/after update).
>
> See attached files. USB not tested yet.
Ah, so GCC only as a build time dependency?
Did you try the USE_GCC=yes:build syntax? If that does not suffice (which
I can see may be the case reviewing at Mk/bsd.gcc.mk and your update) look
into what it might take to address it there to also benefit others with a
similar need and avoid some of the manual coding of your approach?
Note, at this point I am not planning to make this change or a variation
thereof since it's not what the majority of other system and upstream do
(to the best of my knowledge) and Wine on FreeBSD is tricky enough as it
is.
Note 2, I stepped down from maintaining wine-devel, though I did keep it
up to date and bring it into the Wine 10.x era while also updating the
main wine port to Wine 10.0. Should a new maintainer step up, which I
hope, maybe they'll make this change. A drive by commit with bigger
changes like this without assuming maintainership would not be great,
though.
Also, you made a number of further changes compared to current wine-devel:
· reductions to CONFIGURE_ARGS, which qI'm not sure why,
· bumping PORTEPOCH (which looks very wrong), and
· dropping the use of gstreamer.
On the latter there is quite some history here from
commit 27a252c686ad65fff1df4efe19209385408e1f81
Author: Gerald Pfeifer <ger...@freebsd.org>
Date: Sat Aug 27 20:56:47 2011 +0000
Update to Wine 1.3.26. This includes the following changes:
- Support for multisampling in Direct3D.
- New version of the Gecko engine.
- Improvements to the network proxy handling.
- Better write support in MSXML.
- Side-by-side manifests for built-in libraries.
- Various bug fixes.
Explicitly disable gstreamer support, thus avoiding automatic
detection and incorrect package lists in case. [1]
PR: 159749 [1]
Submitted by: Anatoly Borodin <anatoly.boro...@gmail.com> [1]
over enabling it
commit 63ef7d1ab018109313476c9b03632c4fe1ab6633
Author: Gerald Pfeifer <ger...@freebsd.org>
Date: Sun Oct 22 16:07:12 2023 +0000
emulators/wine-devel: Use GStreamer when supporting sound
When ALSA or OSS are enabled, i.e., we have sound enabled, pull
in and use GStreamer as well.
PR: 273987
Reported by: scf
to refining it
commit 132921c8f898c5ca11780b9b87543cce6eb406d2
Author: Alastair Hogge <a...@riseup.net>
Date: Thu Nov 16 11:41:07 2023 +0000
emulators/wine-devel: GSTREAMER dependency cleanup
* Add missing USES=gnome and USE=GNOME=glib20 for GSTREAMER dependencies
* Add ${STRIP_CMD} to GNU configure environment variable ac_cv_prog_STRIP
PR: 274953
This does not mean your change there is intrinsically bad or undesirable.
Just be explicit about it and its rationale and listen to what Sean and
Alistair have to say (regarding their changes and current experiences).
Cheers,
Gerald
PS: In general, my strong recommendation is to make one change at a time,
sharing, discussing and validating it with those interested, instead of
bundling.
