John W. O'Brien wrote:
Despite the appropriate verbiage, I'm not really apt to reset the maintainer unless there have been repeated timeouts. The maintainer did provide feedback, albeit delayed, during the last update in PR 264355. We can revisit maintainer reset if it happens again. In the meantime, I have set the maintainer-feedback flag for timeout.On 6/2/24 10:16, John W. O'Brien wrote:Hello FreeBSD Ports,I believe the patch for [0] that received affirmative review feedback on 2024-05-13 via [1] has exceeded maintainer timeout and is ready to land. If there are any friendly neighborhood committers available to take this, you would have my gratitude.Regards, John [0] https://bugs.freebsd.org/277851 [1] https://reviews.freebsd.org/D45168Would a committer please take this PR?If committers have been reluctant to take this due to the proposed maintainer reset, I believe circumstances now meet all portmgr policy requirements [2] with reasonable margin.2024-03-21 PR reported [0], auto-request for maintainer feedback 2024-04-04 Two week timeout for PR 2024-05-11 Email to current maintainer (private), no response 2024-05-12 Patch posted [0] 2024-05-13 Revision accepted [1] 2024-05-26 Two week timeout for patch, excluding maintainer reset 2024-06-02 First request for a committer 2024-06-21 Three month timeout for maintainer reset 2024-07-20 Second request for a committer [2] https://www.freebsd.org/portmgr/policies_contributors/
Everything else in your diff seems fine as long as it runs as intended. -- Charlie Li ...nope, still don't have an exit line.
OpenPGP_signature.asc
Description: OpenPGP digital signature
