On 15 Dec 2023, at 12:00, Dimitry Andric <d...@freebsd.org> wrote: > > On 15 Dec 2023, at 11:52, Rainer Hurling <rhur...@gwdg.de> wrote: >> >> Am 15.12.23 um 06:39 schrieb Rainer Hurling: >>> Am 15.12.23 um 00:53 schrieb Dimitry Andric: >>>> On 14 Dec 2023, at 21:23, Dimitry Andric <d...@freebsd.org> wrote: >>>>> >>>>> On 14 Dec 2023, at 20:49, Rainer Hurling <rhur...@gwdg.de> wrote: > ... >>>>>> ../../base/containers/checked_iterators.h:248:8: error: no template >>>>>> named '__is_cpp17_contiguous_iterator'; did you mean >>>>>> '__libcpp_is_contiguous_iterator'? >>>>>> 248 | struct >>>>>> __is_cpp17_contiguous_iterator<::base::CheckedContiguousIterator<T>> >>>>>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>>>>> | __libcpp_is_contiguous_iterator > ... >>>> I haven't yet been able to build the port itself as my test machine is >>>> swamped with jobs, but the patch from qt6-webengine applied without >>>> fuzz. Can you please try the attached diff? > ... >> The build and installation are ok, the updated electron25 seems usable, >> tested by updating editors/vscode :D >> >> Attached you will find the almost same patch, but in the naming convention >> of ports, derived by 'make makepatch'. > > Strange, my original patch was also produced by make makepatch. :) > > >> BTW, do we also have to patch other electon versions? > > I'm not sure. The fix is actually from upstream chromium, so if newer > electron versions are based off of a "new enough" chromium snapshot, > they should have it. I will take a look at the sources, because building > these ports is pretty awful: [ 6% 2757/45534] after about an hour. :P
Ok, I have checked devel/electron26 and devel/electron27, and both already have this fix. So I would expect them build. Let me know if they don't. :) -Dimitry
