On Fri, Sep 23, 2022 at 04:05:02PM -0400, Kurt Mosiejczuk wrote:
> On Fri, Sep 23, 2022 at 09:43:37PM +0200, Antoine Jacoutot wrote:
> > On Sun, Sep 18, 2022 at 04:43:36PM -0600, Kurt Mosiejczuk wrote:
> > > CVSROOT:  /cvs
> > > Module name:      ports
> > > Changes by:       [email protected]    2022/09/18 16:43:36
> 
> > > Modified files:
> > >   graphics/pstoedit: Makefile 
> 
> > > Log message:
> > > ports-gcc doesn't check /usr/local for includes or libraries by
> > > default.
> 
> > > Fixes build on sparc64
> 
> > Can it be that it finds libzlib if installed?
> 
> > <...>
> > checking for zip_add in -lzip... yes
> > checking zip.h usability... yes   
> > checking zip.h presence... yes  
> > checking for zip.h... yes
> > <...>
> > => dpb junking
> > c++ -DHAVE_CONFIG_H -I. -DHAVE_MKSTEMP -DHAVE_LIBZIP -DDEFAULTGS=gs 
> > -DPSTOEDITDATADIR="/usr/local/share/pstoedit" -DPST
> > OEDITLIBDIR="/usr/local/lib/pstoedit" -Wall -Wextra -Wuninitialized 
> > -Wswitch-default -Wunused -Wshadow -Wwrite-strings
> > -Wcast-qual -Wpointer-arith -Wno-long-long -I/usr/local/include 
> > -D_LITTLE_ENDIAN -O2 -pipe -DINTERNALBOOL -MT drvpptx.l
> > o -MD -MP -MF .deps/drvpptx.Tpo -c drvpptx.cpp -fPIC -DPIC -o 
> > .libs/drvpptx.o
> > drvpptx.cpp:67:10: fatal error: 'zip.h' file not found
> > #include <zip.h>
> >          ^~~~~~~
> > 1 error generated.
> 
> I haven't seen it, but I can believe it. Should we add archivers/libzip to
> LIB_DEPENDS?

Can't we disable it with a knob?
Anyway, I have no strong opinion whether to enforce the dep or not.

-- 
Antoine

Reply via email to